-
-
Notifications
You must be signed in to change notification settings - Fork 270
London | 26-ITP-Jan | Said Fayaz Sadat | Sprint 2 | Book Library #438
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
8cf25d1
- Fixed syntax error in render loop (missing closing parenthesis).
fayaz551 c163676
update input types for better browser compatibility
fayaz551 087eadc
refine layout for book form and action buttons
fayaz551 9df271a
clean up redundant logic and implement code best practices.
fayaz551 ef8461a
resolved the validation errors and standardized the syntax
fayaz551 6a959c5
reorganized js file structure to follow standard conventions
fayaz551 674677d
finalized data validation and code organization
fayaz551 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,96 +1,65 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <html lang="en"> | ||
| <head> | ||
| <title> </title> | ||
| <meta | ||
| charset="utf-8" | ||
| name="viewport" | ||
| content="width=device-width, initial-scale=1.0" | ||
| /> | ||
| <title>My Book Library</title> | ||
| <meta charset="utf-8"> | ||
| <meta name="viewport" content="width=device-width, initial-scale=1.0"> | ||
|
|
||
| <script src="https://ajax.googleapis.com/ajax/libs/jquery/3.4.1/jquery.min.js"></script> | ||
| <script src="https://cdnjs.cloudflare.com/ajax/libs/popper.js/1.16.0/umd/popper.min.js"></script> | ||
| <script src="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/js/bootstrap.min.js"></script> | ||
| <link | ||
| rel="stylesheet" | ||
| href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css" | ||
| /> | ||
| <link rel="stylesheet" type="text/css" href="style.css" /> | ||
| <link rel="stylesheet" href="https://maxcdn.bootstrapcdn.com/bootstrap/4.4.1/css/bootstrap.min.css"> | ||
| <link rel="stylesheet" type="text/css" href="style.css"> | ||
| </head> | ||
|
|
||
| <body> | ||
| <div class="jumbotron text-center"> | ||
| <h1>Library</h1> | ||
| <p>Add books to your virtual library</p> | ||
| <p>Add books to your library</p> | ||
| </div> | ||
|
|
||
| <button data-toggle="collapse" data-target="#demo" class="btn btn-info"> | ||
| Add new book | ||
| </button> | ||
| <div class="container"> | ||
| <button data-toggle="collapse" data-target="#demo" class="btn btn-info mb-3"> | ||
| Add new book | ||
| </button> | ||
|
|
||
| <div id="demo" class="collapse"> | ||
| <div class="form-group"> | ||
| <label for="title">Title:</label> | ||
| <input | ||
| type="title" | ||
| class="form-control" | ||
| id="title" | ||
| name="title" | ||
| required | ||
| /> | ||
| <label for="author">Author: </label> | ||
| <input | ||
| type="author" | ||
| class="form-control" | ||
| id="author" | ||
| name="author" | ||
| required | ||
| /> | ||
| <label for="pages">Pages:</label> | ||
| <input | ||
| type="number" | ||
| class="form-control" | ||
| id="pages" | ||
| name="pages" | ||
| required | ||
| /> | ||
| <label class="form-check-label"> | ||
| <input | ||
| type="checkbox" | ||
| class="form-check-input" | ||
| id="check" | ||
| value="" | ||
| />Read | ||
| </label> | ||
| <input | ||
| type="submit" | ||
| value="Submit" | ||
| class="btn btn-primary" | ||
| onclick="submit();" | ||
| /> | ||
| <div id="demo" class="collapse mb-4"> | ||
| <div class="card card-body"> | ||
| <div class="form-group"> | ||
| <label for="title">Title:</label> | ||
| <input type="text" class="form-control" id="title" required> | ||
|
|
||
| <label for="author" class="mt-2">Author:</label> | ||
| <input type="text" class="form-control" id="author" required> | ||
|
|
||
| <label for="pages" class="mt-2">Pages:</label> | ||
| <input type="number" class="form-control" id="pages" min="1" step="1" required> | ||
|
|
||
| <div class="form-check mt-3 mb-3"> | ||
| <input type="checkbox" class="form-check-input" id="check"> | ||
| <label class="form-check-label" for="check">I have read this book</label> | ||
| </div> | ||
|
|
||
| <input type="submit" value="Add to Library" class="btn btn-primary" onclick="submit()"> | ||
| </div> | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| <table class="table" id="display"> | ||
| <thead class="thead-dark"> | ||
| <tr> | ||
| <th>Title</th> | ||
| <th>Author</th> | ||
| <th>Number of Pages</th> | ||
| <th>Read</th> | ||
| <th></th> | ||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| <tr> | ||
| <td></td> | ||
| <td></td> | ||
| <td></td> | ||
| <td></td> | ||
| <td></td> | ||
| </tr> | ||
| </tbody> | ||
| </table> | ||
| <table class="table table-hover" id="display"> | ||
| <thead class="thead-dark"> | ||
| <tr> | ||
| <th>Title</th> | ||
| <th>Author</th> | ||
| <th>Pages</th> | ||
| <th>Read Status</th> | ||
| <th>Actions</th> | ||
| </tr> | ||
| </thead> | ||
| <tbody> | ||
| </tbody> | ||
| </table> | ||
| </div> | ||
|
|
||
| <script src="script.js"></script> | ||
| </body> | ||
| </html> | ||
| </html> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,19 +1,44 @@ | ||
| body { | ||
| background-color: #f8f9fa; | ||
| } | ||
|
|
||
| .jumbotron { | ||
| background-color: #343a40; | ||
| color: white; | ||
| border-radius: 0; | ||
| } | ||
|
|
||
| .container { | ||
| margin-top: 20px; | ||
| } | ||
|
|
||
|
|
||
| .form-group { | ||
| width: 400px; | ||
| height: 300px; | ||
| align-self: left; | ||
| padding-left: 20px; | ||
| max-width: 500px; | ||
| margin: 0 auto; | ||
| } | ||
|
|
||
|
|
||
| .btn { | ||
| display: block; | ||
| margin-top: 5px; | ||
| } | ||
|
|
||
| .form-check-label { | ||
| padding-left: 20px; | ||
| margin: 5px 0px 5px 0px; | ||
|
|
||
| #display { | ||
| background-color: white; | ||
| box-shadow: 0 4px 8px rgba(0,0,0,0.05); | ||
| margin-top: 20px; | ||
| } | ||
|
|
||
| button.btn-info { | ||
| margin: 20px; | ||
|
|
||
| .form-check-label { | ||
| padding-left: 5px; | ||
| cursor: pointer; | ||
| } | ||
|
|
||
|
|
||
| .btn-success, .btn-warning { | ||
| display: inline-block; | ||
| margin-right: 5px; | ||
| font-size: 0.85rem; | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.