Skip to content

fix: stabilize posters and filter quick actions - #96

Merged
CodeWithMa merged 6 commits into
CodeWithMa:devfrom
CodeWithMaBot:fix/item-view-quick-actions-posters
Aug 23, 2026
Merged

fix: stabilize posters and filter quick actions#96
CodeWithMa merged 6 commits into
CodeWithMa:devfrom
CodeWithMaBot:fix/item-view-quick-actions-posters

Conversation

@CodeWithMaBot

@CodeWithMaBot CodeWithMaBot commented Aug 23, 2026

Copy link
Copy Markdown
Contributor

fixes #94 and fixes #95

Summary by CodeRabbit

  • New Features

    • Added status-aware quick actions for items, with available actions changing based on item progress.
    • Added image cache refresh support so updated posters and previews appear reliably.
  • Bug Fixes

    • Prevented outdated poster images from replacing newer images during updates or refreshes.
    • Improved poster caching and cleanup when images are replaced, deleted, or fail to load.

@vercel

vercel Bot commented Aug 23, 2026

Copy link
Copy Markdown

@CodeWithMaBot is attempting to deploy a commit to the Ma's projects Team on Vercel.

A member of the Team first needs to authorize it.

@coderabbitai

coderabbitai Bot commented Aug 23, 2026

Copy link
Copy Markdown

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro Plus

Run ID: 77bcbecc-358d-4462-af3c-e741c63067a3

📥 Commits

Reviewing files that changed from the base of the PR and between 92d199c and 0b1596e.

📒 Files selected for processing (9)
  • src/app/components/item-card/item-card.component.ts
  • src/app/components/item-form/item-form.component.spec.ts
  • src/app/components/item-view/item-view.component.spec.ts
  • src/app/components/item-view/item-view.component.ts
  • src/app/components/poster-picker/poster-picker.component.spec.ts
  • src/app/components/poster-picker/poster-picker.component.ts
  • src/app/services/image-invalidation.ts
  • src/app/services/image-storage.service.ts
  • src/app/services/storage.service.ts

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

Image storage now caches object URLs, invalidates them through shared reactive state, and exposes a version signal. Poster loaders reject stale results. Item quick actions now depend on item status.

Changes

Item media and quick actions

Layer / File(s) Summary
Image cache invalidation
src/app/services/image-invalidation.ts, src/app/services/image-storage.service.ts, src/app/services/storage.service.ts
Adds shared invalidation state, cached object URL handling, URL revocation, version updates, and import notifications.
Version-aware poster loading
src/app/components/item-card/item-card.component.ts, src/app/components/item-view/item-view.component.ts, src/app/components/poster-picker/poster-picker.component.ts, src/app/components/item-form/item-form.component.spec.ts, src/app/components/item-view/item-view.component.spec.ts, src/app/components/poster-picker/poster-picker.component.spec.ts
Poster loaders observe the storage version and ignore outdated results. Test mocks provide the version signal.
Status-specific quick actions
src/app/components/item-view/item-view.component.ts, src/app/components/item-view/item-view.component.spec.ts
Quick actions are derived from item status. The completed action is removed, and status-specific action coverage is added.

Estimated code review effort: 4 (Complex) | ~45 minutes

Merge Risk: ⚪ Minimal · up to 0b159

This change is merge-ready after normal checks and review; no actionable merge-blocking risk remains.

Sequence Diagram(s)

sequenceDiagram
  participant StorageService
  participant ImageStorageService
  participant ItemViewComponent
  participant PosterPickerComponent
  StorageService->>ImageStorageService: emit image invalidation
  ImageStorageService->>ImageStorageService: revoke cached URLs and increment version
  ItemViewComponent->>ImageStorageService: read version and load poster
  PosterPickerComponent->>ImageStorageService: read version and load preview
  ImageStorageService-->>ItemViewComponent: return current object URL
  ImageStorageService-->>PosterPickerComponent: return current object URL
Loading
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the two primary changes: poster stabilization and quick-action filtering.
Linked Issues check ✅ Passed The changes stabilize poster loading and show status-appropriate quick actions for issues [#94] and [#95].
Out of Scope Changes check ✅ Passed The image cache invalidation and import refresh changes support reliable poster caching and remain related to poster stabilization.
Docstring Coverage ✅ Passed Docstring check was indeterminate for this PR — some files could not be analyzed in time. Not blocking.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@vercel

vercel Bot commented Aug 23, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
watch-list Ready Ready Preview Aug 23, 2026 10:15am

@CodeWithMa
CodeWithMa merged commit 50bd4f3 into CodeWithMa:dev Aug 23, 2026
6 checks passed
@CodeWithMaBot
CodeWithMaBot deleted the fix/item-view-quick-actions-posters branch August 23, 2026 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

View Item Page - All Quick buttons show up View Item Page - Quick actions reload the poster each time

2 participants