TCP B1: Add TCP client and server packet type enums, plus reading/writing them. - #421
Open
alex-clickhouse wants to merge 1 commit into
Open
TCP B1: Add TCP client and server packet type enums, plus reading/writing them.#421alex-clickhouse wants to merge 1 commit into
alex-clickhouse wants to merge 1 commit into
Conversation
TriageCategory: Summary What this impacts
Concerns
Required reviewer action
|
alex-clickhouse
force-pushed
the
tcp/epic-b1-packet-envelope
branch
from
July 8, 2026 10:26
4b2a8d1 to
af1a936
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds first-class representations of ClickHouse TCP native-protocol packet type codes and convenience read/write helpers, with unit tests validating the VarUInt envelope behavior.
Changes:
- Introduces
ClientPacketTypeandServerPacketTypeenums for packet envelope type codes. - Adds
WriteClientPacketTypeandReadServerPacketTypeAsynchelpers over existing VarUInt primitives. - Extends protocol reader/writer tests to cover round-trips, overlap semantics, and unknown multi-byte codes.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| ClickHouse.Driver.Tcp/Protocol/ServerPacketType.cs | Adds server→client packet type enum and docs (needs doc fixes + backing type adjustment). |
| ClickHouse.Driver.Tcp/Protocol/ClientPacketType.cs | Adds client→server packet type enum and docs (needs doc fixes + backing type adjustment). |
| ClickHouse.Driver.Tcp/Protocol/ClickHouseBinaryWriter.cs | Adds WriteClientPacketType helper that writes the VarUInt type code. |
| ClickHouse.Driver.Tcp/Protocol/ClickHouseBinaryReader.cs | Adds ReadServerPacketTypeAsync helper that reads the VarUInt type code. |
| ClickHouse.Driver.Tcp.Tests/Protocol/ClickHouseBinaryReaderWriterTests.cs | Adds tests for packet type encoding/decoding and envelope composition. |
alex-clickhouse
force-pushed
the
tcp/epic-b1-packet-envelope
branch
from
July 8, 2026 10:35
af1a936 to
00d60cb
Compare
Comment on lines
+4
to
+6
| /// Packet type codes the server sends to the client, encoded as the leading VarUInt of each packet. | ||
| /// Codes overlap numerically with <see cref="ClientPacketType"/> but carry different meanings per direction | ||
| /// (e.g. code 2 is server <see cref="Exception"/> but client <see cref="ClientPacketType.Data"/>). |
Comment on lines
+4
to
+6
| /// Packet type codes the client sends to the server, encoded as the leading VarUInt of each packet. | ||
| /// Codes overlap numerically with <see cref="ServerPacketType"/> but carry different meanings per direction | ||
| /// (e.g. code 2 is client <see cref="Data"/> but server <see cref="ServerPacketType.Exception"/>). |
| } | ||
|
|
||
| [Test] | ||
| public async Task PacketTypeCodes_OverlapAcrossDirections_CarryDifferentMeaning() |
alex-clickhouse
changed the title
alex-clickhouse
force-pushed
the
tcp/epic-b1-packet-envelope
branch
from
July 10, 2026 12:42
00d60cb to
09281f5
Compare
alex-clickhouse
marked this pull request as ready for review
July 15, 2026 08:26
kavirajk
approved these changes
Jul 24, 2026
kavirajk
left a comment
kavirajk
left a comment
There was a problem hiding this comment.
LGTM 👍 looks like all the message types are covered as specs on both clients and server :)
alex-clickhouse
force-pushed
the
tcp/epic-b1-packet-envelope
branch
from
July 28, 2026 18:59
09281f5 to
02bf5c5
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
alex-clickhouse
force-pushed
the
tcp/epic-b1-packet-envelope
branch
from
July 29, 2026 07:05
02bf5c5 to
6ba85af
Compare
alex-clickhouse
force-pushed
the
tcp/epic-b1-packet-envelope
branch
from
July 29, 2026 15:47
6ba85af to
04c8175
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.