feat: support explicit HyperDX Deployment and pod annotations - #255
Open
mfroembgen wants to merge 3 commits into
Open
feat: support explicit HyperDX Deployment and pod annotations#255mfroembgen wants to merge 3 commits into
mfroembgen wants to merge 3 commits into
Conversation
🦋 Changeset detectedLatest commit: dd4a55b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
mfroembgen
force-pushed
the
warren/hyperdx-deployment-annotations
branch
from
July 29, 2026 06:07
6e59624 to
dd4a55b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
hyperdx.deployment.deploymentAnnotationsfor HyperDX Deployment metadatahyperdx.deployment.podAnnotationsfor HyperDX pod-template metadatahyperdx.deployment.annotationsas a deprecated compatibility aliaspodAnnotationswins on duplicate legacy keysMotivation
The existing
hyperdx.deployment.annotationsvalue configuresspec.template.metadata.annotations, but its scope is ambiguous and there is no value for the Deployment object'smetadata.annotations. Explicit names make both Kubernetes metadata surfaces clear without breaking existing installations.Backward compatibility
The new values default to empty maps. Existing
hyperdx.deployment.annotationsvalues continue to render on the pod template. When bothannotationsandpodAnnotationscontain the same key, the explicitpodAnnotationsvalue takes precedence; non-conflicting legacy annotations are preserved.Test plan
helm unittest charts/clickstack— 28 suites, 190 tests passhelm lint charts/clickstackgit diff --checkFixes #254.