Skip to content

Equipment characteristics #47#118

Open
urwahah wants to merge 4 commits into
developmentfrom
equipment-characteristics-#47
Open

Equipment characteristics #47#118
urwahah wants to merge 4 commits into
developmentfrom
equipment-characteristics-#47

Conversation

@urwahah

@urwahah urwahah commented Jun 20, 2026

Copy link
Copy Markdown
Collaborator

per #47: added physical & electrical characteristics to the equipment database. updated some existing data for consistency as well as added some new air-cooled chillers.

also, minor updates to the display values in the equipment table:

  • fixed boolean check (values are np.bool not bool) to show yes/no
  • revised model names to also show the manufacturer name where listed

@urwahah urwahah requested a review from t-kramer June 20, 2026 03:53

@t-kramer t-kramer left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@urwahah Again, only added some minor comments. Please review and let me know if you want to make any adjustments

"refrigerant": "R-454B",
"refrigerant_weight_g": 200000,
"refrigerant_gwp": 466,
"refrigerant": "R-515B",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General question: Do the changes you made to the values below affect the results of the spreadsheet you created for testing?

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes they do - the following equipment that's used in the testing cases was changed slightly (capacity, refrigerant, or efficiency data): hr01, hr03, bo02, bo03, ch02, ch03, res02

Comment thread layout/table_config.py Outdated
Comment thread src/equipment.py Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants