Revise emission scenario names#117
Conversation
urwahah
changed the title
| # scen = {**base_scenario, "em_scen_id": scen_id, "em_scen_name": scen_name} | ||
| scen = {**base_scenario, "em_scen_id": scen_id} | ||
|
|
||
| if group_id == "year": |
There was a problem hiding this comment.
I think the old code always assigned em_scen_name before the if/elif chain. The new code only assigns it inside each branch, correct? If a new group type is added in the future without updating this block, em_scen_name will be missing from the dict, causing a downstream errors.
There was a problem hiding this comment.
that's right. i would expect a name to be defined for each scenario group, similar to the equipment groups.. i know this block is a little confusing, but i saw there's an open issue to create an emissions scenario database (#99) already, so this was just meant as an stopgap before that's resolved (because the A,B,C was hard to follow).
i added a default empty string for now, so if nothing is provided you'd at least notice a blank - is that fine?
alternatively we can just keep the original code that generates a default name from the suffix, which then gets overwritten by the branches
2 participants
changed the name attribute for emission scenarios to be more descriptive instead of A,B,C