Registration page changes - #17
Open
karyao wants to merge 7 commits into
Open
Conversation
karyao
force-pushed
the
2-registration-page-changes
branch
from
August 18, 2026 23:27
568dbd0 to
b027519
Compare
jbriones1
requested changes
Aug 19, 2026
jbriones1
left a comment
jbriones1
left a comment
Contributor
There was a problem hiding this comment.
One question and one fix please :D
Comment on lines
+48
to
+49
| pattern(registration.name, /\S/, { message: 'Enter your name.' }); | ||
| maxLength(registration.name, 80, { message: 'Your name must be 80 characters or fewer.' }); |
Contributor
There was a problem hiding this comment.
Wait, do we actually have this constraint? I can't find a name length limit.
| @@ -20,7 +20,6 @@ import { BrandHeaderComponent } from '../../shared/brand-header/brand-header.com | |||
| interface RegistrationModel { | |||
| registrationKind: RegistrationKind; | |||
Contributor
There was a problem hiding this comment.
Remove registrationKind from the form. We don't use it anymore since it'll always be player and the API doesn't expect it anymore.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor: Registration page
Closes #2
Description:
Removed
Leaderfrom Registration types, also moved sign in for admin to endpoint/adminrather than the regular player sign in.Removed the name for
Adminfor just password and also removing the name from the backend.Future issues: