HIP Vec Filter - #2016
Merged
Merged
Conversation
jeremylt
force-pushed
the
jeremy/hip-vec-filter
branch
from
August 27, 2026 09:54
a1dd1e0 to
6e0b742
Compare
zatkins-dev
approved these changes
Aug 27, 2026
zatkins-dev
left a comment
zatkins-dev
left a comment
Collaborator
There was a problem hiding this comment.
Looks good and passes cleanly locally, thanks!
| @@ -281,7 +281,7 @@ static int CeedVectorSetArray_Hip(const CeedVector vec, const CeedMemType mem_ty | |||
| // Copy host array to value strided | |||
| //------------------------------------------------------------------------------ | |||
| static int CeedHostCopyStrided_Hip(CeedScalar *h_array, CeedSize start, CeedSize stop, CeedSize step, CeedScalar *h_copy_array) { | |||
Collaborator
There was a problem hiding this comment.
Are these host functions actually tested? I think the way we set up the tests, they may not be. We should probably double-check.
Member
Author
There was a problem hiding this comment.
That would probably be a good student issue - modify the tests suite to ensure all these Host functions are tested
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose:
Really, this felt to simple to be a useful student issue anymore
Closes: #1830
LLM/GenAI Disclosure:
none