Skip to content

Hard Coding the strings from activity to matchTemplate.#280

Closed
octacode wants to merge 1 commit into
BuildmLearn:bug-fixesfrom
octacode:HardcodedStrings
Closed

Hard Coding the strings from activity to matchTemplate.#280
octacode wants to merge 1 commit into
BuildmLearn:bug-fixesfrom
octacode:HardcodedStrings

Conversation

@octacode

@octacode octacode commented Dec 12, 2016

Copy link
Copy Markdown
Contributor

#279
I have removed the hard coded the strings from activity folder to match_template folder.
Thanks

@opticod opticod left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octacode, Thanks for the PR.
Please resolve the merge conflicts and follow Snake case naming convention for string ids

@octacode

octacode commented Jan 4, 2017

Copy link
Copy Markdown
Contributor Author

Great, I will make the changes

@octacode

Copy link
Copy Markdown
Contributor Author

@opticod
Thanks for your approval, I have implemented your suggestions and have opened a new PR #399 for the same. Please have a look at it.

@octacode octacode closed this Jan 17, 2017
@octacode octacode deleted the HardcodedStrings branch January 17, 2017 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants