Add formatter implementation into the extension - #4
Open
ikripaka wants to merge 14 commits into
Open
Conversation
ikripaka
marked this pull request as ready for review
July 24, 2026 13:15
gerau
reviewed
Jul 24, 2026
ikripaka
force-pushed
the
feat/formatter
branch
2 times, most recently
from
July 29, 2026 10:48
c81b1f8 to
7a01171
Compare
Collaborator
|
ACK 7a01171; code review, tested locally |
Collaborator
Author
|
After publishing, it automatically installs the |
Collaborator
|
Why dev? Can we rebase it onto main? |
Collaborator
Author
|
Sure, we can |
* add an option to format a file via the right-click menu * add comments and update the README section about formatting * improve the formatting output to make it more meaningful * add notification messages when formatting fails
so it wouldn't open a console every time when we launch formatting
* adjust output messages * remove message about successfull formatting * add comments for functions
…` options for formatter * add gifs to local assets folder * edit README.md
* add test for formatter caching logic and finding executables
* edit tests * move lsp/install common logic into install_executable.ts
ikripaka
force-pushed
the
feat/formatter
branch
from
August 26, 2026 08:23
112f943 to
54ed0ce
Compare
gerau
requested changes
Aug 26, 2026
* set autoSaveBeforeFormat and formatterDisableAutoupdate to false by default * unify document.ts file to use it both for formating and for getting active documents * modify failure notifications (long errors in formatting would be visible in output) * extend tests
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mainly, this pr introduces fmt functionality for the SimplicityHL.
simffiles by using the default formatter association withsimfmt