[STACK tzpnlvnu] refactor(abstract-utxo): drop utxolib RootWalletKeys from keychains.ts#8986
Closed
OttoAllmendinger wants to merge 1 commit into
Closed
Conversation
4 tasks
OttoAllmendinger
force-pushed
the
otto/abstract-utxo-replacements
branch
from
1e3a4b1 to
ea0b137
Compare
Switch the instanceof check and Triple<BIP32> conversion path to use
fixedScriptWallet.RootWalletKeys from wasm-utxo. The other input shapes
(UtxoNamedKeychains, Triple<{pub}>, string[]) continue to work via the
existing toKeychainTriple/string-array branches.
Refs: T1-3279
OttoAllmendinger
force-pushed
the
otto/keychains-drop-utxolib
branch
from
6f4898f to
50b7f4e
Compare
3 tasks
Contributor
Author
|
Collapsing stack into a single PR. These commits are now included in #8987 which targets master directly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Switches the
instanceofcheck andTriple<BIP32>conversion path in keychains.ts to usefixedScriptWallet.RootWalletKeysfrom@bitgo/wasm-utxo. The other input shapes (UtxoNamedKeychains,Triple<{pub}>,string[]) continue to work via the existingtoKeychainTriple/ string-array branches.Stacked on #8915 (jj: tzpnlvnu)
Followed by #8987
PR group context
Stack:
master → #8915 (abstract-utxo-replacements) → this PR (keychains-drop-utxolib) → abstract-utxo-terminalRefs: T1-3279
Test plan
yarn tsc --noEmitclean inmodules/abstract-utxoyarn lintclean inmodules/abstract-utxo🤖 Generated with Claude Code