Skip to content

fix(sdk-core): add tokenName to prebuildConsolidateAccountParams whitelist #8984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bitgo-ai-agent-dev wants to merge 1 commit into
base: master
Choose a base branch
from
+15 −0
Draft

fix(sdk-core): add tokenName to prebuildConsolidateAccountParams whitelist #8984

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 14 additions & 0 deletions modules/bitgo/test/v2/unit/accountConsolidations.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,6 +64,20 @@ describe('Account Consolidations:', function () {
scope.isDone().should.be.True();
});

it('should forward tokenName to the build request', async function () {
const tokenName = 'talgo:USDt';
const scope = nock(bgUrl)
.post(`/api/v2/${wallet.coin()}/wallet/${wallet.id()}/consolidateAccount/build`, { tokenName })
.query({})
.reply(200, fixtures.buildAccountConsolidation);

const accountConsolidationBuild = await wallet.buildAccountConsolidations({ tokenName });

accountConsolidationBuild.length.should.equal(2);

scope.isDone().should.be.True();
});

it('should throw if the result is an empty array', async function () {
const scope = nock(bgUrl)
.post(`/api/v2/${wallet.coin()}/wallet/${wallet.id()}/consolidateAccount/build`)
Expand Down
1 change: 1 addition & 0 deletions modules/sdk-core/src/bitgo/wallet/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,6 +306,7 @@ export class Wallet implements IWallet {
prebuildConsolidateAccountParams(): string[] {
return [
'consolidateAddresses',
'tokenName',
'nftCollectionId',
'nftId',
'feeRate',
Expand Down
Loading