Skip to content

feat(sdk-core): add execType to txrequest intent (CSHLD-972) #8972

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
bitgo-ai-agent-dev wants to merge 1 commit into
base: master
Choose a base branch
from
+29 −0
Draft

feat(sdk-core): add execType to txrequest intent (CSHLD-972) #8972

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions modules/sdk-core/src/bitgo/utils/mpcUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -224,6 +224,7 @@ export abstract class MpcUtils {
recipients: intentRecipients,
tokenName: params.tokenName,
isTestTransaction: params.isTestTransaction,
execType: params.execType,
};

if (baseCoin.isEVM() && baseCoin.supportsTss()) {
Expand Down
7 changes: 7 additions & 0 deletions modules/sdk-core/src/bitgo/utils/tss/baseTypes.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -269,6 +269,11 @@ export interface TokenTransferRecipientParams {
tokenId?: string;
decimalPlaces?: number;
}
export enum ExecType {
EXEC_UNSPECIFIED = 'EXEC_UNSPECIFIED',
EXEC_TRY = 'EXEC_TRY',
}

interface IntentOptionsBase {
reqId: IRequestTracer;
intentType: string;
Expand All @@ -278,6 +283,7 @@ interface IntentOptionsBase {
memo?: Memo;
custodianTransactionId?: string;
custodianMessageId?: string;
execType?: ExecType;
}

/**
Expand Down Expand Up @@ -393,6 +399,7 @@ interface PopulatedIntentBase {
comment?: string;
memo?: string;
isTss?: boolean;
execType?: ExecType;
}

export interface PopulatedIntentForMessageSigning extends PopulatedIntentBase {
Expand Down
2 changes: 2 additions & 0 deletions modules/sdk-core/src/bitgo/wallet/iWallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,7 @@ import {
CustomPaillierModulusGetterFunction,
CustomRShareGeneratingFunction,
CustomSShareGeneratingFunction,
ExecType,
TokenEnablement,
TokenTransferRecipientParams,
TxRequest,
Expand Down Expand Up @@ -297,6 +298,7 @@ export interface PrebuildTransactionOptions {
* Parameters for executing DAML commands on Canton.
*/
cantonCommandParams?: CantonCommandParams;
execType?: ExecType;
}

export interface PrebuildAndSignTransactionOptions extends PrebuildTransactionOptions, WalletSignTransactionOptions {
Expand Down
19 changes: 19 additions & 0 deletions modules/sdk-core/src/bitgo/wallet/wallet.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4181,6 +4181,7 @@ export class Wallet implements IWallet {
unspents: params.unspents,
senderAddress: params.senderAddress,
isTestTransaction: params.isTestTransaction,
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4198,6 +4199,7 @@ export class Wallet implements IWallet {
feeToken: params.feeToken,
unspents: params.unspents,
sequenceId: params.sequenceId,
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4211,6 +4213,7 @@ export class Wallet implements IWallet {
recipients: params.recipients || [],
enableTokens: params.enableTokens,
memo: params.memo,
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4223,6 +4226,7 @@ export class Wallet implements IWallet {
intentType: 'closeAssociatedTokenAccount',
recipients: params.recipients || [],
memo: params.memo,
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4238,6 +4242,7 @@ export class Wallet implements IWallet {
receiveAddress: params.receiveAddress,
feeOptions,
feeToken: params.feeToken,
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4253,6 +4258,7 @@ export class Wallet implements IWallet {
receiveAddress: params.receiveAddress,
feeOptions,
feeToken: params.feeToken,
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4265,6 +4271,7 @@ export class Wallet implements IWallet {
intentType: 'tokenApproval',
tokenName: params.tokenName,
feeToken: params.feeToken,
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4276,6 +4283,7 @@ export class Wallet implements IWallet {
reqId,
intentType: 'createAccount',
recipients: params.recipients || [],
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4288,6 +4296,7 @@ export class Wallet implements IWallet {
intentType: 'transferAccept',
txRequestId: params.txRequestId,
sequenceId: params.txRequestId,
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4301,6 +4310,7 @@ export class Wallet implements IWallet {
intentType: 'transferReject',
txRequestId: params.txRequestId,
sequenceId: params.txRequestId,
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4314,6 +4324,7 @@ export class Wallet implements IWallet {
intentType: 'transferOfferWithdrawn',
transferOfferId: params.transferOfferId,
sequenceId: params.transferOfferId,
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4332,6 +4343,7 @@ export class Wallet implements IWallet {
tokenName: params.tokenName,
sequenceId: params.sequenceId,
comment: params.comment,
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4352,6 +4364,7 @@ export class Wallet implements IWallet {
nonce: params.nonce,
memo: params.memo,
feeOptions,
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4368,6 +4381,7 @@ export class Wallet implements IWallet {
nonce: params.nonce,
feeOptions,
feeToken: params.feeToken,
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4384,6 +4398,7 @@ export class Wallet implements IWallet {
nonce: params.nonce,
feeOptions,
feeToken: params.feeToken,
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4397,6 +4412,7 @@ export class Wallet implements IWallet {
sequenceId: params.sequenceId,
comment: params.comment,
recipients: params.recipients || [],
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4410,6 +4426,7 @@ export class Wallet implements IWallet {
sequenceId: params.sequenceId,
comment: params.comment,
recipients: params.recipients || [],
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4425,6 +4442,7 @@ export class Wallet implements IWallet {
amount: string;
clientIdempotencyKey?: string;
},
execType: params.execType,
},
apiVersion,
params.preview
Expand All @@ -4441,6 +4459,7 @@ export class Wallet implements IWallet {
operationId?: string;
clientIdempotencyKey?: string;
},
execType: params.execType,
},
apiVersion,
params.preview
Expand Down
Loading