Fix macOS entrypoint repair wrappers - #156
Closed
twodogegg wants to merge 1 commit into
Closed
Conversation
Owner
|
啥问题 简单说一下 |
Author
|
Owner
|
Codex++ maintainer review note 当前 main 下这个 PR 仍存在 merge conflict,暂时不能合并。请先 rebase 到最新 main 并解决冲突;更新后我们会重新跑针对性测试再复审。 This PR currently conflicts with main, so it is not mergeable yet. Please rebase onto the latest main and resolve the conflicts, then we can review and test it again. |
Owner
|
当前 已改为在 macOS bundle 中复制并校验 sidecar 二进制,再由稳定入口脚本启动,相关 bundle/重命名问题也经 、、 等后续修复。此 PR 基于旧的 wrapper 写入模型,除图标部分外已被替代;图标问题由范围更小的 #1696 单独跟踪。现关闭本 PR。感谢贡献。 |
Owner
|
补充完整关闭依据:当前 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix macOS entrypoint repair so it does not overwrite installed
.appexecutables with broken shell wrappers.Why
I reproduced this on macOS with the v1.1.1 DMG. After using the manager repair entrypoint action:
/Applications/Codex++.app/Contents/MacOS/CodexPlusPluswas replaced by a shell script that executes itself, so launchingCodex++from Alfred/Finder reports that the app is not responding./Applications/Codex++ 管理工具.app/Contents/MacOS/CodexPlusPlusManagerwas replaced by a wrapper pointing tocodex-plus-plus-manager, but that lowercase binary does not exist inside the app bundle.codex-plus-plus.png, while the DMG app bundle shipscodex-plus-plus.icns, causing launcher/search UIs to show a missing icon.Changes
.appbundles usingCodexPlusPlusManager, matching the packaged filename.codex-plus-plus.icnsin repaired app bundles.Testing
cargo fmt --checkcargo test -p codex-plus-core --test installersNote:
cargo test -p codex-plus-corestill has an unrelated existing failure on macOS inwrapper_dir_uses_roaming_codex_plus_plusbecause it expects Windows backslashes in a Windows-style path constructed on macOS.