Bump openscad_cpp_evaluator to 0.13.5 - #130
Merged
Merged
Conversation
Adds Op::CallChildren, eliminating children()'s native C++ reentry -- the final piece of the Anklet.scad/BOSL2 attachable() fix. Anklet.scad now renders end-to-end (peak native reentry depth 10, down from 55 when the investigation began, vs the Windows-proven-safe ceiling of 40). Also fixes two real pre-existing bugs: the children()/children(N) chunk-cache key collision (wrong geometry emitted), and an indexed- trail out-of-order-pop corrupting $-variable forwarding. See openscad_cpp_evaluator PR #66. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Adds Op::PushCsgWrap/CsgGroupStart/CsgGroupEnd/PopCsgWrap, eliminating union()/difference()/intersection()'s native C++ reentry -- the last construct still capped at kMaxDriveVmNativeDepth=40 when wrapping a recursive call. A wrapped recursive call now compiles straight to Op::CallModule, zero native stack cost, bounded only by the heap-sized kMaxVmCallStackDepth (1,000,000). See openscad_cpp_evaluator PR #67. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
revarbat
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
openscad_cpp_evaluatorpin from>=0.13.4to>=0.13.5(both[project.dependencies]and[tool.briefcase.app.belfryscad]), andbelfryscaditself to 0.20.16.Op::PushCsgWrap/CsgGroupStart/CsgGroupEnd/PopCsgWrap, eliminatingunion()/difference()/intersection()'s native C++ reentry — the last construct still capped atkMaxDriveVmNativeDepth=40when wrapping a recursive call. See openscad_cpp_evaluator PR #67.Test plan
uv lockresolved cleanly against the newly-published 0.13.5 wheels.🤖 Generated with Claude Code