Conversation
Review Summary by QodoAdd PostgreSQL 14.23, 15.18, 16.14, 17.10, 18.4 with configuration files
WalkthroughsDescription• Add PostgreSQL versions 14.23, 15.18, 16.14, 17.10, 18.4 with configuration files • Create initialization scripts, configuration files, and version-specific settings for each PostgreSQL version • Move bundle configuration from gradle.properties to separate build.properties file • Fix Gradle build by separating build properties from Gradle configuration Diagramflowchart LR
A["PostgreSQL Versions<br/>14.23, 15.18, 16.14,<br/>17.10, 18.4"] --> B["Configuration Files<br/>bearsampp.conf<br/>postgresql.conf.ber<br/>pg_hba.conf.ber"]
A --> C["Init Scripts<br/>init.bat"]
D["gradle.properties"] -- "Move bundle config" --> E["build.properties"]
File Changes1. bin/postgresql14.23/init.bat
|
Code Review by Qodo
1. Initdb path unquoted
|
Contributor
🐘 PostgreSQL Module Tests - ResultsTest Date: 2026-06-05 21:18:24 UTC 📊 Test Results by Version
Results: 5 of 5 versions tested All tests passed successfully! ✨ 📋 Test PhasesEach version is tested through the following phases:
Check artifacts for detailed logs. |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| @@ -0,0 +1,5 @@ | |||
| @ECHO OFF | |||
|
|
|||
| %~dp0bin\initdb.exe -U postgres -A trust -E utf8 -D "%~dp0data" > "~BEARSAMPP_WIN_PATH~\logs\postgresql-install.log" 2>&1 | |||
There was a problem hiding this comment.
1. Initdb path unquoted 🐞 Bug ☼ Reliability
The new init.bat scripts invoke %~dp0bin\initdb.exe without quoting the executable path, which will fail when the module path contains spaces. This breaks database initialization and leaves the PostgreSQL bundle unusable.
Agent Prompt
### Issue description
Windows batch parsing splits on spaces; calling `%~dp0bin\initdb.exe` without quotes fails when `%~dp0` contains spaces.
### Issue Context
This pattern exists in all newly added PostgreSQL version folders’ `init.bat`.
### Fix Focus Areas
- bin/postgresql14.23/init.bat[1-5]
- bin/postgresql15.18/init.bat[1-5]
- bin/postgresql16.14/init.bat[1-5]
- bin/postgresql17.10/init.bat[1-5]
- bin/postgresql18.4/init.bat[1-5]
### What to change
- Update the invocation to quote the executable path, e.g.:
- `"%~dp0bin\initdb.exe" -U postgres ...`
- Keep the existing quoting for `-D "%~dp0data"` as-is.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
Comment on lines
+2
to
+3
| host all all 127.0.0.1/32 trust | ||
| host all all ::1/128 trust |
There was a problem hiding this comment.
2. Trust auth enabled 🐞 Bug ⛨ Security
The new PostgreSQL bundles initialize and configure authentication as trust, allowing any local OS user to connect as any database role (including postgres) without a password. This enables unauthorized database access on shared/multi-user machines.
Agent Prompt
### Issue description
The bundle uses `trust` authentication in both cluster initialization (`initdb -A trust`) and runtime access rules (`pg_hba.conf`), allowing passwordless access.
### Issue Context
Even though `pg_hba.conf` is limited to localhost, `trust` still permits any local user to authenticate as any DB role.
### Fix Focus Areas
- bin/postgresql14.23/init.bat[1-5]
- bin/postgresql14.23/pg_hba.conf.ber[1-3]
- bin/postgresql15.18/init.bat[1-5]
- bin/postgresql15.18/pg_hba.conf.ber[1-3]
- bin/postgresql16.14/init.bat[1-5]
- bin/postgresql16.14/pg_hba.conf.ber[1-3]
- bin/postgresql17.10/init.bat[1-5]
- bin/postgresql17.10/pg_hba.conf.ber[1-3]
- bin/postgresql18.4/init.bat[1-5]
- bin/postgresql18.4/pg_hba.conf.ber[1-3]
### What to change
- Change `initdb` auth to a password-based method (e.g., `-A scram-sha-256` or `-A md5`) and ensure an initial superuser password is set/managed.
- Update `pg_hba.conf.ber` entries to match (e.g., `scram-sha-256` instead of `trust`) for localhost rules.
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
…tency across build.gradle Co-authored-by: Junie <junie@jetbrains.com>
|
Code review by qodo was updated up to the latest commit 6f12581 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
Enhancement
Description
Add PostgreSQL versions 14.23, 15.18, 16.14, 17.10, 18.4 with configuration files
Create initialization scripts and configuration templates for each PostgreSQL version
Move bundle configuration from gradle.properties to separate build.properties file
Update bundle release version to 2025.6.2
Diagram Walkthrough
File Walkthrough
22 files
Windows initialization script for PostgreSQL 14.23Bearsampp configuration for PostgreSQL 14.23PostgreSQL server configuration template 14.23PostgreSQL host-based authentication template 14.23Windows initialization script for PostgreSQL 15.18Bearsampp configuration for PostgreSQL 15.18PostgreSQL server configuration template 15.18PostgreSQL host-based authentication template 15.18Windows initialization script for PostgreSQL 16.14Bearsampp configuration for PostgreSQL 16.14PostgreSQL server configuration template 16.14PostgreSQL host-based authentication template 16.14Windows initialization script for PostgreSQL 17.10Bearsampp configuration for PostgreSQL 17.10PostgreSQL server configuration template 17.10PostgreSQL host-based authentication template 17.10Windows initialization script for PostgreSQL 18.4Bearsampp configuration for PostgreSQL 18.4PostgreSQL server configuration template 18.4PostgreSQL host-based authentication template 18.4New build properties file with bundle configurationRemove bundle configuration moved to build.properties