Merged
Conversation
…rt and update bundle release to 2026.6.2
Review Summary by QodoAdd PHP 8.3.31, 8.4.22, and 8.5.7 configurations with extension support and update bundle release to 2026.6.2
WalkthroughsDescription• Added complete configuration support for three new PHP versions: 8.3.31, 8.4.22, and 8.5.7 • Each PHP version includes comprehensive php.ini configuration files with core directives, memory limits (512M), execution timeouts, and error reporting settings • Configured essential PHP extensions for each version: curl, fileinfo, gd, intl, mbstring, mysqli, openssl, pdo_mysql, pdo_pgsql, pdo_sqlite, pgsql, and sodium • Added extension properties files (exts.properties) for each PHP version specifying download URLs for imagick, memcache, xdebug, and zip extensions • Created Bearsampp configuration files (bearsampp.conf) for each PHP version with CLI executables and Apache 2.4 module settings • Added dependency configuration files (deps.properties) for ImageMagick 7.1.2-24 support across all three PHP versions • Included PEAR configuration files (pear.properties) referencing pearweb_phars 1.10.26 • Added documentation files explaining the purpose of the deps directory for each PHP version • Updated bundle release version from 2026.4.18 to 2026.6.2 in build.properties Diagramflowchart LR
A["Bundle Release 2026.4.18"] -- "update version" --> B["Bundle Release 2026.6.2"]
B -- "add PHP 8.3.31" --> C["PHP 8.3.31 Config"]
B -- "add PHP 8.4.22" --> D["PHP 8.4.22 Config"]
B -- "add PHP 8.5.7" --> E["PHP 8.5.7 Config"]
C -- "includes" --> F["php.ini, exts, deps, pear, bearsampp.conf"]
D -- "includes" --> F
E -- "includes" --> F
File Changes1. bin/php8.3.31/php.ini
|
Code Review by Qodo
1. Missing release manifest entries
|
Contributor
🐘 PHP Module Tests - ResultsTest Date: 2026-06-03 03:08:50 UTC 📊 Test Results by VersionPHP 8.5.5
PHP 8.5.3
PHP 8.5.2
PHP 8.5.0
PHP 8.4.20
Results: 20 of 20 tests completed All tests passed successfully! ✨ 📋 Test PhasesEach version is tested through the following phases:
Check artifacts for detailed logs. |
![qodo-code-review[bot]](https://avatars.githubusercontent.com/in/484649?s=60&v=4){kind=small}
| @@ -0,0 +1,9 @@ | |||
| phpVersion = "8.3.31" | |||
There was a problem hiding this comment.
1. Missing release manifest entries 🐞 Bug ☼ Reliability
The CI workflow detects PHP versions from new/changed bin/php<version>/ folders and requires those versions to exist in releases.properties (it also reads the download URL from that file). This PR adds 8.3.31, 8.4.22, and 8.5.7 under bin/, but releases.properties has no entries for them, so CI and consumers cannot resolve/download the corresponding archives.
Agent Prompt
### Issue description
New PHP version directories were added under `bin/` (8.3.31, 8.4.22, 8.5.7) but the release manifest `releases.properties` was not updated. CI and downstream tooling expect every version present in `bin/` to have a corresponding `releases.properties` entry (version -> downloadable .7z URL).
### Issue Context
The CI/CD workflow:
- Detects versions from changed `/bin` directories and **verifies** they exist in `releases.properties`.
- Downloads the `.7z` archive using the URL from `releases.properties`.
### How to fix
Add entries for the new versions to `releases.properties`, following the existing format:
- `8.3.31 = https://github.com/Bearsampp/module-php/releases/download/2026.6.2/bearsampp-php-8.3.31-2026.6.2.7z`
- `8.4.22 = https://github.com/Bearsampp/module-php/releases/download/2026.6.2/bearsampp-php-8.4.22-2026.6.2.7z`
- `8.5.7 = https://github.com/Bearsampp/module-php/releases/download/2026.6.2/bearsampp-php-8.5.7-2026.6.2.7z`
(Keep ordering consistent with the file’s current version sorting.)
### Fix Focus Areas
- releases.properties[1-30]
- bin/php8.3.31/bearsampp.conf[1-3]
- bin/php8.4.22/bearsampp.conf[1-3]
- bin/php8.5.7/bearsampp.conf[1-3]
ⓘ Copy this prompt and use it to remediate the issue with your preferred AI generation tools
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.