fix(tui): show an honest empty state when /plan opens before attach - #37
Merged
Conversation
Opening the plan tab with no live session (no client / no session id) rendered "loading plan…" forever: fetchPlan was a silent no-op, so no reply ever resolved the placeholder and nothing retried it. syncPlanPanelMsg now reports the not-attached state explicitly; the existing reset + refetch-at-tail on attach resolves the tab to a real snapshot.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Opening
/plan(slash command or drawer tab) with no live session renderedloading plan…permanently.openPlan()rendered the placeholder, thenfetchPlan()silently returned nil — no request, no error, no poll, no retry. The copy could never resolve.Fix
syncPlanPanelMsggains a leading not-attached case that states why the tab is empty:Once a run attaches, the existing reset + refetch-at-tail path resolves the tab to a real snapshot.
Testing
TestPlanTab_UnattachedOpenerNeverShowsEternalLoading— red first (reproduced the exact stuck copy), green after the fix.make fmt/make vet/make lint(0 issues) /make test(race suite) all pass.