Build the Windows and UWP CI jobs with Visual Studio 2026 - #222
Draft
bghgary wants to merge 1 commit into
Draft
Conversation
Both workflows were the last pins left on windows-2022 while macOS already runs macos-26, so the Windows toolchain was the one place CI could not see compiler drift coming. Pins the explicit windows-2025-vs2026 label rather than windows-latest or windows-2025. Those resolve to Windows Server 2025 but not to a fixed Visual Studio version -- actions/runner-images#14004 reports the windows-2025 label serving the VS2026 image, and #14140 reports two jobs in a single run landing on different images and breaking MSVC LTCG linking.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Created by Copilot on behalf of @bghgary]
Context
Both Windows workflows were the last pins on
windows-2022while macOS already runsmacos-26, so the Windows toolchain was the one place CI could not see compiler drift coming. Opened as a draft to get real CI signal across every engine and both UWP architectures.Worth a look
windows-2025-vs2026rather thanwindows-latestorwindows-2025. Those resolve to Windows Server 2025 but not to a fixed Visual Studio version: actions/runner-images#14004 reports thewindows-2025label serving the VS2026 image, and #14140 reports two jobs in one run landing on different images and breaking MSVC LTCG linking.mainat9271f13bconfigures and builds clean with VS2026 (MSVC 14.51.36231) for-A x64 -D NAPI_JAVASCRIPT_ENGINE=JSI, RelWithDebInfo, withTreatWarningAsErroron for the targets that pull in GSL. The other engines and both UWP architectures are what this PR is for.18.7.12002.237; the runner image ships18.8.12023.21.