Skip to content

[agentserver-responses] Keep newest history item IDs when applying limit #48560

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Hashim Khan (Hashim1999164) wants to merge 2 commits into
base: main
Choose a base branch
from
Open

[agentserver-responses] Keep newest history item IDs when applying limit #48560

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1f130cb
Keep newest history item IDs when applying limit
Hashim1999164 Aug 12, 2026
3d675a3
Keep newest history ids under the limit and fix changelog
Hashim1999164 Aug 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion sdk/agentserver/azure-ai-agentserver-responses/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@
# Release History

## 2.1.0b1 (2026-08-11)
## 2.1.0b1 (2026-08-13)

### Bugs Fixed

- `get_history_item_ids` on the in-memory and file stores now keeps the newest item IDs when applying `limit`. (#48514)

### Breaking Changes

Expand Down
3 changes: 2 additions & 1 deletion sdk/agentserver/azure-ai-agentserver-responses/azure/ai/agentserver/responses/store/_file.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -579,7 +579,8 @@ async def get_history_item_ids(

if limit <= 0:
return []
return resolved[:limit]
# Keep the most recent N history items (drop oldest when over limit).
return resolved[-limit:]

# ------------------------------------------------------------------
# Internal helpers (must be called with self._lock held)
Expand Down
3 changes: 2 additions & 1 deletion ...gentserver/azure-ai-agentserver-responses/azure/ai/agentserver/responses/store/_memory.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -325,7 +325,8 @@ async def get_history_item_ids(

if limit <= 0:
return []
return resolved[:limit]
# Keep the most recent N history items (drop oldest when over limit).
return resolved[-limit:]

async def create_execution(self, execution: ResponseExecution, *, ttl_seconds: int | None = None) -> None:
"""Create a new execution and replay container for ``execution.response_id``.
Expand Down
3 changes: 2 additions & 1 deletion sdk/agentserver/azure-ai-agentserver-responses/tests/unit/test_file_response_store_parity.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -327,7 +327,8 @@ async def test_history_respects_limit(tmp_path: Path) -> None:
history_item_ids=["hist1", "hist2"],
)
ids = await provider.get_history_item_ids("r_prev", None, limit=3)
assert ids == ["hist1", "hist2", "in1"]
# Chronological order is oldest-first; truncation must keep the newest IDs.
assert ids == ["out1", "out2", "out3"]
# Non-positive limit returns empty.
ids_zero = await provider.get_history_item_ids("r_prev", None, limit=0)
assert ids_zero == []
Expand Down
2 changes: 2 additions & 0 deletions sdk/agentserver/azure-ai-agentserver-responses/tests/unit/test_in_memory_provider_crud.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -374,6 +374,8 @@ def test_history__respects_limit() -> None:

ids = asyncio.run(provider.get_history_item_ids("resp_lim", None, 3))
assert len(ids) == 3
# Chronological order is oldest-first; truncation must keep the newest IDs.
assert ids == ["in_lim_7", "in_lim_8", "in_lim_9"]


def test_history__zero_limit_returns_empty() -> None:
Expand Down