[AutoPR azure-iot-deviceregistry-softwareupdate]-generated-from-SDK Generation - Java-6715272 - #50175
Open
azure-sdk-automation[bot] wants to merge 1 commit into
Conversation
…ry/tspconfig.yaml', SDK Release Type: beta, and CommitSHA: '83ee12a23d0ab5a14b990f8b5700e787eb8a0b7c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6715272 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release.
azure-sdk-automation
Bot
added
the
auto-release
|
Azure Pipelines: Successfully started running 1 pipeline(s). 35 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot could not run the full agentic suite for this review because it was automatically requested on a bot-authored pull request. Request a review from Copilot under Reviewers to retry with the full agentic suite. Improved support for bot-authored pull requests is coming soon.
Adds a new Java SDK module for Device Registry Software Update, wiring it into the deviceregistry Maven reactor and release pipeline.
Changes:
- Adds new
azure-iot-deviceregistry-softwareupdatemodule to the deviceregistry SDK build. - Introduces generated client, models, samples, and generated (disabled) tests for the Software Update data-plane.
- Updates CI/release configuration and versioning metadata to include the new artifact.
Reviewed changes
Copilot reviewed 42 out of 72 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk/deviceregistry/pom.xml | Adds the new software update module to the deviceregistry Maven reactor. |
| sdk/deviceregistry/ci.yml | Adds release toggle/configuration for the new artifact in the deviceregistry pipeline. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/tsp-location.yaml | Pins TypeSpec generation input to a specific REST API specs directory/commit. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/test/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateListVersionsTests.java | Adds generated test stub for listing update versions (currently disabled). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/test/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateListUpdatesTests.java | Adds generated test stub for listing updates (currently disabled). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/test/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateListProvidersTests.java | Adds generated test stub for listing providers (currently disabled). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/test/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateListOperationStatusesTests.java | Adds generated test stub for listing operation statuses (currently disabled). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/test/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateListNamesTests.java | Adds generated test stub for listing names (currently disabled). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/test/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateListFilesTests.java | Adds generated test stub for listing files (currently disabled). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/test/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateImportUpdateTests.java | Adds generated test stub for import LRO (currently disabled). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/test/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateGetUpdateTests.java | Adds generated test stub for getUpdate (currently disabled). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/test/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateGetOperationStatusTests.java | Adds generated test stub for getOperationStatus (currently disabled). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/test/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateGetFileTests.java | Adds generated test stub for getFile (currently disabled). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/test/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateDeleteUpdateTests.java | Adds generated test stub for delete LRO (currently disabled). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/test/java/com/azure/iot/deviceregistry/softwareupdate/generated/DeviceRegistrySoftwareUpdateClientTestBase.java | Adds shared test base for playback/record/live configuration. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/test/java/com/azure/iot/deviceregistry/softwareupdate/generated/DeviceClassesListTests.java | Adds generated test stub for device classes list (currently disabled). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/test/java/com/azure/iot/deviceregistry/softwareupdate/generated/DeviceClassesGetDeviceClassTests.java | Adds generated test stub for device class get (currently disabled). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/test/java/com/azure/iot/deviceregistry/softwareupdate/generated/DeviceClassesDeleteTests.java | Adds generated test stub for device class delete (currently disabled). |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateListVersions.java | Adds generated sample for listVersions. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateListUpdates.java | Adds generated sample for listUpdates. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateListProviders.java | Adds generated sample for listProviders. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateListOperationStatuses.java | Adds generated sample for listOperationStatuses. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateListNames.java | Adds generated sample for listNames. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateListFiles.java | Adds generated sample for listFiles. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateImportUpdate.java | Adds generated sample for beginImportUpdate. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateGetUpdate.java | Adds generated sample for getUpdate. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateGetOperationStatus.java | Adds generated sample for getOperationStatus. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateGetFile.java | Adds generated sample for getFile. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/generated/SoftwareUpdateDeleteUpdate.java | Adds generated sample for beginDeleteUpdate. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/generated/DeviceClassesList.java | Adds generated sample for device classes list. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/generated/DeviceClassesGetDeviceClass.java | Adds generated sample for device class get. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/generated/DeviceClassesDelete.java | Adds generated sample for device class delete. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/samples/java/com/azure/iot/deviceregistry/softwareupdate/ReadmeSamples.java | Adds README sample region placeholder class. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/resources/azure-iot-deviceregistry-softwareupdate.properties | Adds package name/version resource used by the builder for UA/versioning. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/resources/META-INF/azure-iot-deviceregistry-softwareupdate_metadata.json | Adds generator metadata mapping and api version information. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/module-info.java | Adds JPMS module definition for the new library. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/package-info.java | Adds package-level documentation for the public client package. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/package-info.java | Adds package-level documentation for models. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/UpdateOperation.java | Adds generated model for operation metadata. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/UpdateInfo.java | Adds generated model for update info in operation status. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/UpdateId.java | Adds generated model for update identity. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/UpdateFileDownloadHandler.java | Adds generated model for file download handler metadata. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/UpdateFileBase.java | Adds generated base model for file metadata. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/UpdateFile.java | Adds generated model for update file metadata. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/Update.java | Adds generated model for update metadata. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/StepType.java | Adds generated expandable enum for step type. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/Step.java | Adds generated model for instruction steps. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/OperationState.java | Adds generated expandable enum for operation state. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/Instructions.java | Adds generated model for install instructions. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/ImportUpdateRequest.java | Adds generated model for import update request. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/ImportUpdateInputItem.java | Adds generated model for import update input item. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/ImportManifestMetadata.java | Adds generated model for import manifest metadata. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/FileImportMetadata.java | Adds generated model for import file metadata. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/DeviceClassProperties.java | Adds generated model for device class properties. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/DeviceClass.java | Adds generated model for device class. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/Compatibility.java | Adds generated model for free-form compatibility. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/models/BestCompatibleUpdate.java | Adds generated model for best compatible update. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/implementation/package-info.java | Adds package-level documentation for implementation internals. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/implementation/DeviceRegistrySoftwareUpdateClientImpl.java | Adds generated internal client container and pipeline wiring. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/implementation/DeviceClassesImpl.java | Adds generated REST proxy implementation for device classes. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/SoftwareUpdateClient.java | Adds generated synchronous client for software update APIs with convenience overloads. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/DeviceRegistrySoftwareUpdateServiceVersion.java | Adds service version enum with latest preview version. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/DeviceRegistrySoftwareUpdateClientBuilder.java | Adds generated builder for sync/async clients and pipeline configuration. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/DeviceClassesClient.java | Adds generated synchronous device classes client with convenience methods. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/src/main/java/com/azure/iot/deviceregistry/softwareupdate/DeviceClassesAsyncClient.java | Adds generated async device classes client with convenience methods. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/pom.xml | Adds Maven module definition and dependencies for the new library. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/assets.json | Adds assets tracking metadata for release tooling. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/README.md | Adds initial README for the new package. |
| sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/CHANGELOG.md | Adds initial changelog entry for beta.1. |
| eng/versioning/version_client.txt | Registers the new artifact in versioning catalog. |
Suppressed comments (2)
sdk/deviceregistry/ci.yml:1
- The new release toggle defaults to
true, while the existing deviceregistry release toggles in this pipeline default tofalse. This can unintentionally batch-release the new artifact on runs where no explicit parameter is set. Recommend setting the default tofalse(or matching the established default for this pipeline) and enabling it explicitly when intended.
sdk/deviceregistry/azure-iot-deviceregistry-softwareupdate/tsp-location.yaml:1 additionalDirectoriesis present but has no value, which will be parsed asnullin YAML. If tooling expects this to be a list, this can create special-case handling or parsing failures. Prefer setting it explicitly to an empty list (additionalDirectories: []) or removing the key when unused.
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+51
to
+67
| <version>1.59.0</version> <!-- {x-version-update;com.azure:azure-core;dependency} --> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.azure</groupId> | ||
| <artifactId>azure-core-http-netty</artifactId> | ||
| <version>1.16.6</version> <!-- {x-version-update;com.azure:azure-core-http-netty;dependency} --> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.azure</groupId> | ||
| <artifactId>azure-core-test</artifactId> | ||
| <version>1.27.0-beta.17</version> <!-- {x-version-update;com.azure:azure-core-test;dependency} --> | ||
| <scope>test</scope> | ||
| </dependency> | ||
| <dependency> | ||
| <groupId>com.azure</groupId> | ||
| <artifactId>azure-identity</artifactId> | ||
| <version>1.18.4</version> <!-- {x-version-update;com.azure:azure-identity;dependency} --> |
Comment on lines
+9
to
+15
| ### Breaking Changes | ||
|
|
||
| ### Bugs Fixed | ||
|
|
||
| ### Other Changes | ||
| ### Features Added | ||
|
|
Comment on lines
+9
to
+16
| ### Breaking Changes | ||
|
|
||
| ### Bugs Fixed | ||
|
|
||
| ### Other Changes | ||
| ### Features Added | ||
|
|
||
| - Initial release for the azure-iot-deviceregistry-softwareupdate Java SDK. |
Comment on lines
+41
to
+43
| ```java com.azure.iot.deviceregistry.softwareupdate.readme | ||
| ``` | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Configurations: 'specification/deviceupdate/data-plane/sudeviceregistry/tspconfig.yaml', SDK Release Type: beta, and CommitSHA: '83ee12a23d0ab5a14b990f8b5700e787eb8a0b7c' in SpecRepo: 'https://github.com/Azure/azure-rest-api-specs' Pipeline run: https://dev.azure.com/azure-sdk/internal/_build/results?buildId=6715272 Refer to https://eng.ms/docs/products/azure-developer-experience/develop/sdk-release/sdk-release-prerequisites to prepare for SDK release. Release plan link: https://azsdk-releaseplan-dashboard-hveph5aqhhcfhtgu.westus-01.azurewebsites.net/?releaseplan=36134 Submitted by: wuaustin@microsoft.com