-
Notifications
You must be signed in to change notification settings - Fork 2.2k
Bifrostbase/create session #50157
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
browndav-msft
wants to merge
51
commits into
Azure:feature/storage/bifrost-private-drop
Choose a base branch
from
browndav-msft:bifrostbase/createSession
base: feature/storage/bifrost-private-drop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Bifrostbase/create session #50157
Changes from all commits
Commits
Show all changes
51 commits
Select commit
Hold shift + click to select a range
31ac05b
Feature/storage/bifrost create session (#49448)
browndav-msft e127ec4
fix bug in storage session credential with get content length 0
browndav-msft d5d8177
patch to enable session with environement variables
browndav-msft 94145b4
Potential fix for pull request finding
ibrandes 3160091
add code to ensure container name only accepted when session enabled
browndav-msft cce0354
fix formatting and javadocs alignment
browndav-msft ba61f35
add forceRefreshSessionInBackground() to SessionTokenCredentialPolicy
browndav-msft 40c0598
remove .env initialization for sessions
browndav-msft 0622cbc
change SessionCredentialCache to AutoRefreshingCache<T>
browndav-msft b4bc240
rename params for SessionTokenCrednetialPolicy
browndav-msft 2d40a90
add autorefreshcasche specific tests for blob session credential
browndav-msft 1e0e530
wip
browndav-msft ac6fdc1
Session provider lifecycle refactor: expand public contract, move cac…
browndav-msft aeb1424
remove sessionacquisitioncooldown, remove log entry
browndav-msft 35275b6
remove SessionRequestSigner, rename SessionClient to SessionProvider
browndav-msft d9eb0ee
rename SessionProviderSeamTests to SessionProviderTests
browndav-msft aa11c92
create helper method for session provider inside BuilderHelper
browndav-msft 9fea2ca
refactor beginAccountCooldown
browndav-msft d80245f
inline error codes, make async code easier to read
browndav-msft e6fb314
rename BlobSessionProvider to TokenCredentialSessionProvider
browndav-msft f69d4bb
consolidate testing resources in session package in common, improve s…
browndav-msft 38c9310
rework SessionTokenCredentialPolicyTest to remove warnings
browndav-msft 3ae4d1c
remove normal and trims from TokenCredentialSessionProviderCacheTests
browndav-msft 7b85643
remove unnecessary tests in BuilderHelper
browndav-msft 7d92af1
add recordings for tests
browndav-msft b00b3c1
fix linting
browndav-msft 06b2453
consolidate session mocks to scriptedHttpClient, remove createSession…
browndav-msft 84a6691
refactor builderhelper test to test customer provided SessionProvider
browndav-msft b6c6fbb
clean up javadoc for sessionprovider, remove unneeded returns for Scr…
browndav-msft c930e79
add support for dfs hns
browndav-msft 3ced75e
create live tests for datalake
browndav-msft 703b16e
add public accessors to session methods
browndav-msft dfd0f88
fix failing compilations, update swagger to use 105
browndav-msft 1e9157a
merge in recordings from create session
browndav-msft dd138a5
remove container level createSession calls from public api, fix tests…
browndav-msft 1fe704c
undo spacing from builder helper
browndav-msft 1a7c47a
fix builder helper so that diff shows appropriately for createBearerP…
browndav-msft 353bede
fix bytebuddy testing dependency in pom
browndav-msft 2adae2f
Share post-authentication pipeline policies with the CreateSession pi…
browndav-msft 7d50ad2
Cool down accounts that repeatedly reject session credentials
browndav-msft a71a6be
Sanitize session secrets and mark DataLake session tests live-only
browndav-msft e981101
De-duplicate pipeline construction in BuilderHelper
browndav-msft b45b3fb
moved helps from SessionTestHelper to BlobTestBase
browndav-msft 20c3124
Throttle background refresh retries after a failed session creation
browndav-msft aad68b6
Pin the reentrant forced-refresh behavior of AutoRefreshingCache
browndav-msft 60fded3
Fix reentrant forced-refresh behavior for joiners
browndav-msft e4d92e4
Remove redundant session credential shadow-copy from ContainerSession…
browndav-msft 844a1aa
Refine session test HTTP transports
browndav-msft 8d2fd04
Localize the CreateSession test transport
browndav-msft 34e29da
Observe session auth requests with the wire tap client
browndav-msft 79a3d27
Align session auth javadocs with the cooldown implementation
browndav-msft File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
session auth is only configurable on
BlobServiceClientBuilder, and this container builder (andBlobClientBuilder) pass null forsessionOptionsand expose nosessionOptions(...)setter. this would be fine if our clients didnt reuse eachother sometimes, but sinceBlobServiceClient.getBlobContainerClientreuses the service pipeline, any service-derived containers get sessions, but aBlobContainerClient/BlobClientbuilt directly with aTokenCredentialwill silently get bearer-only, with no way to enable or disable sessions.given the session model is inherently container-scoped, this asymmetry might be surprising to customers (two clients that look equivalent authenticate differently based on how they were constructed). can we either add the setter here for consistency, or document the limitation explicitly? might be good to talk about this with gauri too.