Skip to content

feat(routines): use the Routines GA API #9632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Hui Miao (huimiu) wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

feat(routines): use the Routines GA API #9632

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 1 addition & 13 deletions cli/azd/extensions/azure.ai.routines/internal/pkg/routines/client.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,9 +23,7 @@ import (
)

const (
routinesAPIVersion = "v1"
routinesPreviewHeader = "Foundry-Features"
routinesPreviewValue = "Routines=V1Preview"
routinesAPIVersion = "v1"
)

const (
Expand Down Expand Up @@ -146,17 +144,12 @@ func (c *Client) routineRunsURL(routineName string, extraQuery ...string) string
return base
}

func addPreviewHeader(req *policy.Request) {
req.Raw().Header.Set(routinesPreviewHeader, routinesPreviewValue)
}

// GetRoutine retrieves a routine by name.
func (c *Client) GetRoutine(ctx context.Context, name string) (*Routine, error) {
req, err := runtime.NewRequest(ctx, http.MethodGet, c.routineURL(name))
if err != nil {
return nil, fmt.Errorf("failed to create request: %w", err)
}
addPreviewHeader(req)

resp, err := c.readPipeline.Do(req)
if err != nil {
Expand Down Expand Up @@ -202,7 +195,6 @@ func (c *Client) getPage(ctx context.Context, pageURL string, out any) error {
if err != nil {
return fmt.Errorf("failed to create request: %w", err)
}
addPreviewHeader(req)

resp, err := c.readPipeline.Do(req)
if err != nil {
Expand All @@ -223,7 +215,6 @@ func (c *Client) PutRoutine(ctx context.Context, name string, body *Routine) (*R
if err != nil {
return nil, fmt.Errorf("failed to create request: %w", err)
}
addPreviewHeader(req)

if err := setJSONBody(req, body); err != nil {
return nil, err
Expand Down Expand Up @@ -252,7 +243,6 @@ func (c *Client) DeleteRoutine(ctx context.Context, name string) error {
if err != nil {
return fmt.Errorf("failed to create request: %w", err)
}
addPreviewHeader(req)

resp, err := c.writePipeline.Do(req)
if err != nil {
Expand Down Expand Up @@ -284,7 +274,6 @@ func (c *Client) postRoutineAction(ctx context.Context, name, action string) (*R
if err != nil {
return nil, fmt.Errorf("failed to create request: %w", err)
}
addPreviewHeader(req)

resp, err := c.writePipeline.Do(req)
if err != nil {
Expand Down Expand Up @@ -313,7 +302,6 @@ func (c *Client) DispatchRoutineAsync(
if err != nil {
return nil, fmt.Errorf("failed to create request: %w", err)
}
addPreviewHeader(req)

if payload != nil {
if err := setJSONBody(req, payload); err != nil {
Expand Down
2 changes: 1 addition & 1 deletion cli/azd/extensions/azure.ai.routines/internal/pkg/routines/client_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -93,7 +93,7 @@ func TestGetRoutine_Success(t *testing.T) {
client, _ := newTestClient(t, http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) {
assert.Equal(t, http.MethodGet, r.Method)
assert.Contains(t, r.URL.Path, "/routines/my-routine")
assert.Equal(t, routinesPreviewValue, r.Header.Get(routinesPreviewHeader))
assert.Empty(t, r.Header.Get("Foundry-Features"))
assert.Equal(t, "read", r.Header.Get("X-Test-Pipeline"))

w.Header().Set("Content-Type", "application/json")
Expand Down
Loading