{CI} Sync squad mapping labels from ADO Wiki to resourceManagement.yml#33585
Closed
azclibot wants to merge 1 commit into
Closed
{CI} Sync squad mapping labels from ADO Wiki to resourceManagement.yml#33585azclibot wants to merge 1 commit into
azclibot wants to merge 1 commit into
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
microsoft-github-policy-service
Bot
requested review from
wangzelin007 and
yonzhan
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the GitHub policy configuration in resourceManagement.yml to keep squad-routing metadata in sync with the “Squad Mapping” ADO wiki, ensuring issues/PRs get the appropriate squad labels, mentions, and (where applicable) review requests.
Changes:
- Add additional squad
mentioneesentries in relevantmentionUsersblocks based on the squad mapping. - Add additional
addLabelactions to apply mapped squad labels alongside existing labels. - Add additional
requestReviewactions on PR-routing rules to include mapped squad reviewers.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jsntcy
reviewed
Jun 18, 2026
| @@ -748,6 +748,7 @@ configuration: | |||
| mentionees: | |||
| - Azure/deployments-owners | |||
| - act-codegen-extensibility-squad | |||
Member
There was a problem hiding this comment.
act-codegen-extensibility-squad is just a label, but not a team, we should mention a team.
jsntcy
reviewed
Jun 18, 2026
| mentionees: | ||
| - Azure/deployments-owners | ||
| - act-codegen-extensibility-squad | ||
| - Azure/act-identity-squad |
Member
There was a problem hiding this comment.
Our logic should replace existing mentionees instead of appending to them.
jsntcy
reviewed
Jun 18, 2026
| - addLabel: | ||
| label: act-codegen-extensibility-squad | ||
| - addLabel: | ||
| label: act-experience-enablement-squad |
Member
There was a problem hiding this comment.
We should replace the label act-codegen-extensibility-squad instead of appending to the end.
jsntcy
reviewed
Jun 18, 2026
| - requestReview: | ||
| reviewer: act-codegen-extensibility-squad | ||
| - requestReview: | ||
| reviewer: act-observability-squad |
Member
There was a problem hiding this comment.
We should replace existing reviewers instead of appending to it.
jsntcy
reviewed
Jun 18, 2026
| @@ -7052,13 +7121,17 @@ configuration: | |||
| reviewer: yonzhan | |||
| - requestReview: | |||
| reviewer: act-codegen-extensibility-squad | |||
Member
There was a problem hiding this comment.
act-codegen-extensibility-squad is a label, but not a team. We should assign to a team to review, such as Azure/act-codegen-extensibility-squad.
Member
|
@a0x1ab, It seems the sync logic is not correct and added some comments above. |
Member
|
Thank you Yu, I shall work on fixing this now 🫡 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR synchronizes squad labels in resourceManagement.yml based on the Squad Mapping ADO wiki page.