Fix camelCase ending with S incorrectly treated as plural#553
Merged
necusjz merged 2 commits intoJun 19, 2026
Conversation
necusjz
approved these changes
Jun 19, 2026
necusjz
changed the title
S incorrectly treated as plural
necusjz
reviewed
Jun 19, 2026
Comment on lines
+215
to
+216
| head, _, last_token = name.rpartition('-') | ||
| singular_name = head + last_token |
Member
There was a problem hiding this comment.
it covers xxxxT, etc. as well (won't cause the issue). but suppose to be workable.
LGTM.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
generate_command_group_name_by_resourcesingularizes each path segment viato_singular. When a segment ends in an acronym whose final character is a capital letter (e.g.activateSaaS),camel_case_to_snake_casetokenizes it asactivate-saa-s.to_singularthen strips the trailingstoken, producingactivate-saa-— a name with a dangling-separator that is unusable as a command group name.This change detects the case where singularization leaves a trailing separator and falls back to the original (un-singularized) name, so the generated name stays valid (e.g.
activateSaaS->activate-saa-s). Ordinary plural segments (e.g.virtualMachines->virtual-machine) are unaffected.Testing Guide