Skip to content

Remove internal classification references - #6

Closed
Vlad G (vladpm) wants to merge 3 commits into
mainfrom
fix/remove-internal-markers
Closed

Remove internal classification references#6
Vlad G (vladpm) wants to merge 3 commits into
mainfrom
fix/remove-internal-markers

Conversation

@vladpm

@vladpm Vlad G (vladpm) commented Aug 13, 2026

Copy link
Copy Markdown
Contributor

Summary

Remove public-source wording that implied a restricted Microsoft classification, strengthen release hygiene so equivalent wording cannot be reintroduced, and clear the required dependency audit gate.

Implementation

  • Point the editable architecture diagram to the public Excalidraw editor.
  • Replace the validator's literal wording with fragment-built checks for restricted Microsoft classifications and internal-use-only markers.
  • Update the transitive nanoid lock entry from 3.3.16 to 3.3.17 to resolve GHSA-2v37-7h3g-55p8.
  • Preserve each repository's existing history and all runtime, infrastructure, data, and application behavior.

Validation

  • npm run lint
  • npm run typecheck
  • npm test
  • npm run build
  • npm audit --audit-level=low
  • npm run docs:check
  • npm run validate:release
  • Bicep compiled when infrastructure changed (not applicable)
  • Containers built when Dockerfiles/runtime dependencies changed (not applicable)

Additional checks:

  • node --check scripts/validate-public-release.mjs
  • git diff --check
  • Tracked-source scan reports zero restricted classification phrases.
  • Clean install resolves postcss -> nanoid@3.3.17 and reports zero vulnerabilities.

Review checklist

  • The change is focused and follows existing ownership boundaries.
  • Tests cover changed behavior and failure paths.
  • Documentation and configuration contracts are updated.
  • No credentials, Azure identifiers, customer data, personal data, generated output, or large binaries were added.
  • Security and privacy impacts were assessed.
  • Accessibility was tested for affected user journeys (not applicable; no UI change)
  • Responsible AI guidance/evaluation was updated for AI behavior changes (not applicable)
  • Cost and operational impacts were assessed for infrastructure or runtime changes (not applicable)
  • Database changes include a reviewed migration and recovery approach (not applicable; no database change)

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Removes internal-classification wording from public-facing docs and strengthens the public release validator to prevent restricted/internal markers from being reintroduced, while also updating a transitive dependency in the lockfile to clear an audit advisory.

Changes:

  • Updates docs/architecture.md to point the editable diagram to the public Excalidraw editor.
  • Expands scripts/validate-public-release.mjs forbidden-text detection to cover multiple restricted/internal marker variants via fragment-built regexes.
  • Updates the transitive nanoid lock entry to 3.3.17 to address the referenced security advisory.

Reviewed changes

Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.

File Description
scripts/validate-public-release.mjs Replaces the prior literal “Microsoft internal only” check with broader fragment-built regex checks for restricted/internal markers.
package-lock.json Bumps the transitive nanoid entry to 3.3.17 (including resolved URL and integrity).
docs/architecture.md Repoints the editable diagram instructions from an internal Excalidraw instance to the public editor.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread scripts/validate-public-release.mjs Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@vladpm

Copy link
Copy Markdown
Contributor Author

Closing to consolidate this cleanup into a larger upcoming change. Local edits are preserved in the workspace and will return in a follow-up PR.

@vladpm
Vlad G (vladpm) deleted the fix/remove-internal-markers branch August 13, 2026 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants