Remove internal classification references - #6
Closed
Vlad G (vladpm) wants to merge 3 commits into
Closed
Conversation
There was a problem hiding this comment.
Pull request overview
Removes internal-classification wording from public-facing docs and strengthens the public release validator to prevent restricted/internal markers from being reintroduced, while also updating a transitive dependency in the lockfile to clear an audit advisory.
Changes:
- Updates
docs/architecture.mdto point the editable diagram to the public Excalidraw editor. - Expands
scripts/validate-public-release.mjsforbidden-text detection to cover multiple restricted/internal marker variants via fragment-built regexes. - Updates the transitive
nanoidlock entry to3.3.17to address the referenced security advisory.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripts/validate-public-release.mjs | Replaces the prior literal “Microsoft internal only” check with broader fragment-built regex checks for restricted/internal markers. |
| package-lock.json | Bumps the transitive nanoid entry to 3.3.17 (including resolved URL and integrity). |
| docs/architecture.md | Repoints the editable diagram instructions from an internal Excalidraw instance to the public editor. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
Closing to consolidate this cleanup into a larger upcoming change. Local edits are preserved in the workspace and will return in a follow-up PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Remove public-source wording that implied a restricted Microsoft classification, strengthen release hygiene so equivalent wording cannot be reintroduced, and clear the required dependency audit gate.
Implementation
nanoidlock entry from 3.3.16 to 3.3.17 to resolve GHSA-2v37-7h3g-55p8.Validation
npm run lintnpm run typechecknpm testnpm run buildnpm audit --audit-level=lownpm run docs:checknpm run validate:releaseAdditional checks:
node --check scripts/validate-public-release.mjsgit diff --checkpostcss -> nanoid@3.3.17and reports zero vulnerabilities.Review checklist