Fix PHPUnit dependency mount lifecycle#1883
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Encode PHPUnit dependency mount paths with real newlines so managed post-install loading receives each plugin directory.
What changed
How to test
npm run build; expect Workspace build completes successfully..npx tsx tests/phpunit-project-autoload.test.ts; expect Generated PHP contains newline-delimited dependency mounts..npm run test:playground-phpunit-readonly-cache-integration; expect Real Playground managed PHPUnit lifecycle passes..Compatibility
Restores the documented inactive extra_plugins plus dependencyMounts contract from #1868. Single-mount callers remain unchanged; multi-mount callers now load every declared plugin as intended.
Evidence
AI assistance
Source relationships