Skip to content

Fix runner workspace default branch resolution#1866

Merged
chubes4 merged 1 commit into
mainfrom
fix/1864-runner-workspace-default-branch
Jul 18, 2026
Merged

Fix runner workspace default branch resolution#1866
chubes4 merged 1 commit into
mainfrom
fix/1864-runner-workspace-default-branch

Conversation

@chubes4

@chubes4 chubes4 commented Jul 18, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • Preserve explicit runner_workspace.base precedence and the base_branch compatibility alias.
  • When neither is set, resolve the target repository default through the existing authenticated GitHub REST helper and apply the existing branch-safety contract.
  • Reject missing or invalid metadata defaults with a clear error.

Source Evidence

  • Source relationship: issue Resolve omitted publication base from repository default branch #1864 identifies the generic runner-workspace GitHub publisher defaulting to main instead of the target repository default branch.
  • Change kind: bounded runtime branch-resolution correction plus deterministic publisher tests.
  • Verification capability: mocked authenticated REST calls verify explicit and alias paths skip metadata, metadata-derived non-main branches publish correctly, and missing/unsafe metadata fails before publication.
  • Scope: the runtime change only replaces the omitted-configuration main fallback; configured branch behavior, alias support, API authentication, and the established branch predicate are retained.

Tests

  1. npm run test:runner-workspace-publisher
  2. TMPDIR=/tmp npm run test:agent-task-contracts

Compatibility

Configured runner_workspace.base remains authoritative and base_branch remains supported. Unconfigured publishers now target each repository metadata default branch rather than assuming main.

Fixes #1864

AI Assistance

Assisted by OpenAI openai/gpt-5.6-terra.

@chubes4
chubes4 merged commit ff87a60 into main Jul 18, 2026
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resolve omitted publication base from repository default branch

1 participant