Faster fill/strokeText - #2612
Open
chearon wants to merge 2 commits into
Open
Conversation
I noticed that cairo_show_glyphs was slower vs when Pango calls it. Pango holds the FT_Face until the process ends. node-canvas now keeps it until the thread/InstanceData is deleted. Seems not great to me, but if Pango does it that way, let's wait until it becomes a problem.
I noticed that cairo_show_glyphs was _still_ slower vs when Pango calls it. Suspecting another instance had caching info attached, I read the Cairo source code to confirm it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I found a performance regression in v4 with
fillTextonce I looked at real-world numbers. Added a benchmark tomasterthat shows it.FT_Facestores caching info andcairo_set_font_sizecan destroy caching info as well.