Skip to content

Plugins/Themes screens: fix WordPress.com banner logos and equalize banner heights - #51114

Open
lucasmendes-design wants to merge 1 commit into
trunkfrom
fix/wpcom-admin-banner-logos
Open

Plugins/Themes screens: fix WordPress.com banner logos and equalize banner heights#51114
lucasmendes-design wants to merge 1 commit into
trunkfrom
fix/wpcom-admin-banner-logos

Conversation

@lucasmendes-design

Copy link
Copy Markdown

Proposed changes

Fixes three visual issues with the WordPress.com banners shown on the wp-admin Plugins and Themes screens (jetpack-mu-wpcom: wpcom-plugins and wpcom-themes features):

  • Plugins banner logo rendered huge. The logo SVG shipped without intrinsic width/height attributes and the stylesheet had no rule constraining the img, so the logo inflated to the full content width. The banner logo is now pinned to the standard 21px lockup height, and the replacement SVG carries intrinsic dimensions as a fallback.
  • Themes banner used the old WordPress.com lockup. Both banners now use the current WordPress.com logo lockup from the approved brand assets — white on the dark Plugins banner, brand blue (#3858E9) on the light Themes banner.
  • Banner heights didn't match. The Plugins banner CTA now uses the same vertical metrics as the Themes banner (padding: 14px 24px, margin-top: 17px), and the content column is widened to 640px so the heading fits on one line. Both banners now render at the same height (332px at desktop width, previously 443px vs 336px).

Other information

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

None — visual bug fix reported by the WordPress.com brand/design team.

Does this pull request change what data or activity we track or use?

No.

Testing instructions

  1. On a WordPress.com site (Simple or Atomic), go to Plugins → Add New Plugin.
  2. The dark WordPress.com banner should show the logo lockup at 21px height (not oversized), with the heading on one line.
  3. Go to Appearance → Themes.
  4. The light banner should show the current WordPress.com lockup in brand blue (not the old logo).
  5. Both banners should be the same height at desktop widths, and behave as before at narrower breakpoints (≤1260px, ≤850px, ≤782px).

- Replace both banner logo SVGs with the current approved WordPress.com
  lockup (white for the dark Plugins banner, brand blue for the light
  Themes banner). The Themes banner was still using the old lockup.
- Pin the banner logo to the standard 21px lockup height. The Plugins
  logo SVG shipped without intrinsic dimensions and no CSS constraint,
  so it inflated to the full content width.
- Align the Plugins banner CTA metrics with the Themes banner and let
  the heading fit one line, so both banners render at the same height.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WoA dev site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin (WordPress.com Site Helper), and enable the fix/wpcom-admin-banner-logos branch.
  • To test on Simple, run the following command on your sandbox:
bin/jetpack-downloader test jetpack-mu-wpcom-plugin fix/wpcom-admin-banner-logos

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • 🔴 Add a "[Status]" label (In Progress, Needs Review, ...).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Make sure to test your changes on all platforms that it applies to. You're responsible for the quality of the code you ship.
  3. You can use GitHub's Reviewers functionality to request a review.
  4. When it's reviewed and merged, you will be pinged in Slack to deploy the changes to WordPress.com simple once the build is done.

If you have questions about anything, reach out in #jetpack-developers for guidance!

@github-actions github-actions Bot added the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Aug 7, 2026
@lucasmendes-design
lucasmendes-design marked this pull request as ready for review August 7, 2026 12:32
@jp-launch-control

Copy link
Copy Markdown

Code Coverage Summary

No summary data is available for parent commit 1872134, so cannot calculate coverage changes. 😴

If that commit is a feature branch rather than a trunk commit, this is expected. Otherwise, this should be updated once coverage for 1872134 is available.

Full summary · PHP report · JS report

@lucasmendes-design

Copy link
Copy Markdown
Author
wpcom-banners-after wpcom-banners-before

@lucasmendes-design

Copy link
Copy Markdown
Author

Hi @lancewillett there, who can review this for me? Thanks

@lancewillett

Copy link
Copy Markdown
Contributor

@lucasmendes-design I will review and reply, but might not be fast or done today. This type of change takes a bit longer as it requires wpcomsh and WP Cloud testing.

@lancewillett

Copy link
Copy Markdown
Contributor

One note on the testing instructions, step 3: Go to Appearance → Themes. is incorrect. Should be Go to Appearance → Add Theme (or Add New Theme).

This step also exits early if wpcom_admin_interface is wp-admin — so needs testing with "Classic" interface vs. the default (Calypso). Following the steps when using default style doesn't show the banners at all.

@lancewillett lancewillett left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified this independently on an WP Cloud dev site, with the branch installed through Jetpack Beta as jetpack-mu-wpcom-plugin (build from f319779638). My measurements match your screenshots exactly:

Before After
Plugins banner 443px 332px
Themes banner 336px 332px
Plugins logo 540×81 154×21

Plugins screen, before / after at 1440px:

Image Image

Themes screen, before / after at 1440px:

Image Image

AI use: I tested and drafted this comment with help from claude-opus-5

@lancewillett lancewillett removed the [Status] Needs Author Reply We need more details from you. This label will be auto-added until the PR meets all requirements. label Aug 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants