Skip to content

Test resolved grid layout semantics#625

Merged
chubes4 merged 1 commit into
trunkfrom
fix/issue-620-blocks-engine
Jul 18, 2026
Merged

Test resolved grid layout semantics#625
chubes4 merged 1 commit into
trunkfrom
fix/issue-620-blocks-engine

Conversation

@chubes4

@chubes4 chubes4 commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Summary

  • lock inline CSS grid containers to core/group rather than core/columns
  • cover the same precedence when grid declarations come from resolved stylesheet CSS
  • protect the generic grid guard landed in Preserve resolved grid layout semantics #621 against regression

Closes #620.

How to test

  1. Check out this branch on a fresh clone.
  2. Run composer --working-dir=php-transformer test:parity.
  3. Confirm all 243 parity fixtures pass.
  4. Run composer --working-dir=php-transformer test.
  5. Confirm the PHP transformer contracts and package-install proof pass.

Backwards compatibility

This is regression coverage only and does not change runtime behavior or extension paths. It codifies the behavior already shipped by #621: source CSS grid geometry takes precedence over the heuristic Columns conversion.

AI assistance

  • AI assistance: Yes
  • Tool(s): OpenAI gpt-5.6-sol via OpenCode
  • Used for: Investigated representative SSI failures, drafted parity fixtures, and verified the transformer suites. Chris remains responsible for every line.

@chubes4
chubes4 merged commit 7965429 into trunk Jul 18, 2026
1 check passed
@chubes4
chubes4 deleted the fix/issue-620-blocks-engine branch July 18, 2026 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Preserve resolved CSS grid layouts instead of emitting flex Columns blocks

1 participant