Skip to content

Match Mode Cancel Button [SYNTH-312] - #1473

Merged
PepperLola merged 5 commits into
devfrom
alexey/312/cancel-match-mode
Aug 17, 2026
Merged

Match Mode Cancel Button [SYNTH-312]#1473
PepperLola merged 5 commits into
devfrom
alexey/312/cancel-match-mode

Conversation

@AlexD717

@AlexD717 AlexD717 commented Aug 3, 2026

Copy link
Copy Markdown
Member

Task

SYNTH-312

Symptom

With the new UI top bar there is now no simple way to abort a match once it has started.

Solution

Add a new button to the Match Mode panel that shows up when a match is playing allowing users to abort the match.

Verification

After starting a match you can then abort the match through the match mode panel.


Before merging, ensure the following criteria are met:

  • All acceptance criteria outlined in the ticket are met.
  • Necessary test cases have been added and updated.
  • A feature toggle or safe disable path has been added (if applicable).
  • User-facing polish:
    • Ask: "Is this ready-looking?"
  • Cross-linking between Jira and GitHub:
    • PR links to the relevant Jira issue.
    • Jira ticket has a comment referencing this PR.

@AlexD717 AlexD717 self-assigned this Aug 3, 2026
@AlexD717 AlexD717 added the ui/ux Relating to user interface, or in general, user experience label Aug 3, 2026
@AlexD717
AlexD717 force-pushed the alexey/312/cancel-match-mode branch from 33dcc5b to d275ccb Compare August 3, 2026 19:15
@AlexD717
AlexD717 marked this pull request as ready for review August 3, 2026 19:19
@AlexD717
AlexD717 requested review from a team as code owners August 3, 2026 19:19
@AlexD717 AlexD717 changed the title Match Mode Abort UI Option [SYNTH-312] Match Mode Cancel Button [SYNTH-312] Aug 4, 2026

@rutmanz rutmanz left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels a little funky from a flow perspective. I think it would be a lot more straightforward to have the old behavior where the icon changes to a flag with a red slash through it and the tooltip says "Abort match mode." There's no other match mode config that it makes sense to change during that time IMO

Image

@rutmanz

rutmanz commented Aug 4, 2026

Copy link
Copy Markdown
Member
Screenshot 2026-08-04 at 8 44 48 AM

@AlexD717
AlexD717 requested a review from rutmanz August 4, 2026 16:34

@Dhruv-0-Arora Dhruv-0-Arora left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PepperLola PepperLola left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall, but I think the red line doesn't have enough contrast with the background. I think a brighter red might work a bit better

@AlexD717

AlexD717 commented Aug 5, 2026

Copy link
Copy Markdown
Member Author

I can make the red line a bit thicker and brighter, but the button highlight is something that is introduced in PR #1470 so I can't do that unless that gets merged, or I just reimplement the highlighting portion of its features.

@RoushilS RoushilS left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@PepperLola
PepperLola self-requested a review August 17, 2026 22:57
@PepperLola
PepperLola merged commit cc51a88 into dev Aug 17, 2026
25 checks passed
@PepperLola
PepperLola deleted the alexey/312/cancel-match-mode branch August 17, 2026 23:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ui/ux Relating to user interface, or in general, user experience

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants