Match Mode Cancel Button [SYNTH-312] - #1473
Conversation
33dcc5b to
d275ccb
Compare
[SYNTH-312][SYNTH-312]
rutmanz
left a comment
There was a problem hiding this comment.
This feels a little funky from a flow perspective. I think it would be a lot more straightforward to have the old behavior where the icon changes to a flag with a red slash through it and the tooltip says "Abort match mode." There's no other match mode config that it makes sense to change during that time IMO
PepperLola
left a comment
There was a problem hiding this comment.
Looks good overall, but I think the red line doesn't have enough contrast with the background. I think a brighter red might work a bit better
|
I can make the red line a bit thicker and brighter, but the button highlight is something that is introduced in PR #1470 so I can't do that unless that gets merged, or I just reimplement the highlighting portion of its features. |

Task
SYNTH-312
Symptom
With the new UI top bar there is now no simple way to abort a match once it has started.
Solution
Add a new button to the Match Mode panel that shows up when a match is playing allowing users to abort the match.
Verification
After starting a match you can then abort the match through the match mode panel.
Before merging, ensure the following criteria are met: