Skip to content

fix(mobile): render Discover Weekly as a lineup with a header tile #14578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dylanjeffers merged 1 commit into from
Aug 28, 2026
+43 −39
Merged

fix(mobile): render Discover Weekly as a lineup with a header tile #14578

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
82 changes: 43 additions & 39 deletions packages/mobile/src/screens/discover-weekly-screen/DiscoverWeeklyScreen.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,48 +95,52 @@ export const DiscoverWeeklyScreen = () => {
})
}, [trackIds.length, trackEvent])

const header = (
<Flex ph='l' pt='l'>
<Paper row gap='l' alignItems='center' p='l'>
<Image
source={discoverWeeklyArt}
style={{ width: ART_SIZE, height: ART_SIZE, borderRadius: 8 }}
/>
<Flex column gap='xs' style={{ flex: 1 }}>
<Text variant='title' size='l'>
{exploreMessages.discoverWeekly}
</Text>
<Text variant='body' size='s' color='subdued'>
{exploreMessages.discoverWeeklySubtitle}
</Text>
{trackIds.length ? (
<Text variant='body' size='s' color='subdued'>
{exploreMessages.discoverWeeklyTrackCount(trackIds.length)}
</Text>
) : null}
<Button
variant='primary'
size='small'
iconLeft={isPlaying ? IconPause : IconPlay}
onPress={handlePlay}
disabled={!trackIds.length}
>
{isPlaying ? 'Pause' : 'Play'}
</Button>
</Flex>
</Paper>
</Flex>
)

return (
<Screen title={messages.title} topbarRight={null} variant='secondary'>
<ScreenContent>
<Paper m='l' gap='l' h='100%'>
<Flex row gap='l' alignItems='center' p='l'>
<Image
source={discoverWeeklyArt}
style={{ width: ART_SIZE, height: ART_SIZE, borderRadius: 8 }}
/>
<Flex column gap='xs' style={{ flex: 1 }}>
<Text variant='title' size='l'>
{exploreMessages.discoverWeekly}
</Text>
<Text variant='body' size='s' color='subdued'>
{exploreMessages.discoverWeeklySubtitle}
</Text>
{trackIds.length ? (
<Text variant='body' size='s' color='subdued'>
{exploreMessages.discoverWeeklyTrackCount(trackIds.length)}
</Text>
) : null}
<Button
variant='primary'
size='small'
iconLeft={isPlaying ? IconPause : IconPlay}
onPress={handlePlay}
disabled={!trackIds.length}
>
{isPlaying ? 'Pause' : 'Play'}
</Button>
</Flex>
</Flex>
<TrackLineup
trackIds={trackIds}
source='DISCOVER_WEEKLY_TRACKS'
isPending={isPending}
isFetching={isFetching}
hasNextPage={false}
loadNextPage={() => {}}
pageSize={30}
/>
</Paper>
<TrackLineup
trackIds={trackIds}
source={DISCOVER_WEEKLY_SOURCE}
isPending={isPending}
isFetching={isFetching}
hasNextPage={false}
loadNextPage={() => {}}
pageSize={30}
header={header}
/>
</ScreenContent>
</Screen>
)
Expand Down
Loading