feat: add trip summary panel#745
Open
strandlie wants to merge 4 commits into
Open
Conversation
Introduce a shared TripSummaryPanel rendering the route map plus a summary card with price, total travel time and total walk distance. The details body now uses it in place of the map + duration/walk-distance overlay, so the details view also shows the trip price. Add a 'summary' variant to the Price component (rendering a SummaryRow) and the split label/value translations it needs.
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
strandlie
changed the title
Match the design: the departure time is the only thing left of the decoration line. Every other label moves into the content column to its right — the transport icon (with line number) next to the destination, and the walk/wait icons plus the message boxes (situations, notices, rail-replacement, interchange, booking) rendered with their own icon. The left column now holds only the time, left-aligned with the trip's left edge.
strandlie
force-pushed
the
strandlie/trip-detail-summary
branch
from
80cfcb2 to
04fdec6
Compare
The priceLabel translation line exceeded prettier's print width, failing the tsc/check-all CI job. Reflow it across multiple lines.
The trip summary panel now carries price, travel time and walk distance, so the duration and price rows in the details header are redundant. Remove them (keeping the title and date) and add a little spacing between the header and the body below it.
rosvik
reviewed
Jun 26, 2026
rosvik
left a comment
rosvik
left a comment
Member
There was a problem hiding this comment.
Noticed a few things here:
- There are a bunch of comments added here that I don't think adds much. Could you have a look through and remove the ones you don't think are necessary?
- There is a lot of extra padding in the mobile layout:
| style.mapContainer, | ||
| mapHeight === 'page' && style.mapContainer__page, | ||
| )} | ||
| tabIndex={-1} |
Member
There was a problem hiding this comment.
Why -1 tab index here? I'm still able to tab to the map on firefox. (Which I also think I should be able to)
| flex-direction: column; | ||
| gap: token('spacing.medium'); | ||
| padding: token('spacing.large'); | ||
| border: 1px solid token('color.background.neutral.1.background'); |
Member
There was a problem hiding this comment.
On the trip details page, this border is the same color as the background - is that by design? I'm noticing that it appears in the transition between light and dark mode, which looks a bit strange.
Comment on lines
+447
to
450
| `pris (1 ${traveller})`, | ||
| `price (1 ${traveller})`, | ||
| `pris (1 ${traveller})`, | ||
| ), |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Next step of https://github.com/AtB-AS/kundevendt/issues/23752
Figma
Improvements to the trip-detail view, to make TPW ready for the new Trip Card
Screenshots
Changes
TripSummaryPanel: route map + a summary card with price, total travel time and total walk distance. The details body now uses it instead of the map + duration/walk-distance overlay, so the details page also shows the trip price.Pricegains asummaryvariant (renders aSummaryRow), plus the split label/value translations it needs.TripRowlabelAlignoption; the label column is tightened.