Prevent semantic token collisions and stabilize duplicate contrast rows#13
Merged
Conversation
Artsen
marked this pull request as ready for review
July 26, 2026 00:11
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
role-*semantic token before allocating base palette tokens.Root cause
Base palette tokens were deduplicated only against earlier palette names. They were not checked against generated Tailwind semantic keys, and the count-based allocator could also produce a token already requested by another palette name. Separately, contrast rows used only displayed HEX pairs as React keys even though deterministic backend snapshots can contain distinct entries with identical displayed values.
User impact
A color name such as
Role primary actionnow receives a deterministic collision-safe base token such asrole-primary-action-2, while the generated semantic key remainsrole-primary-action. CSS aliases reference the same final base token used by Tailwind. Duplicate contrast pairs and issues all render, with no synthetic key exposed in the interface.Contract scope
Validation
python check.py: passedpnpm review:screenshots: passed; 16 deterministic screenshots generatedgit diff --check: passedRemaining limitations
Token suffixes are intentionally order-dependent because palette order defines deterministic allocation. The
role-*Tailwind namespace is reserved for ColorCraft-generated semantics and cannot be claimed verbatim by a base palette token.