⚡ Bolt: Optimize yEnc decoding - #176
Conversation
What: Replaced byte-by-byte iteration with C-backed bytes.find() and bytes.translate(). Why: yEnc decoding is a major bottleneck when verifying article bodies; manual byte iteration is very slow in Python. Impact: ~15x faster decoding in benchmarks. Measurement: Python timeit testing shows decoding time for typical articles drops from 0.033s to 0.0018s. Co-authored-by: xbmc4lyfe <273732874+xbmc4lyfe@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
📝 WalkthroughSummary by CodeRabbit
Walkthrough
ChangesNZB verification updates
Estimated code review effort: 2 (Simple) | ~10 minutes Mergeability Score: ⚪ Minimal · up to The PR substantially speeds up yEnc decoding. Focused tests for escaped and malformed inputs should be added as follow-up, but no actionable merge-blocking risk remains. Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Warning Billing warning: we have not been able to collect payment for this subscription for more than 72 hours. Please update the payment method or pay any pending invoices in Billing to avoid service interruption. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Not up to standards ⛔🔴 Issues
|
| Category | Results |
|---|---|
| ErrorProne | 1 high |
🟢 Metrics 0 complexity · 0 duplication
Metric Results Complexity 0 Duplication 0
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
🧹 Nitpick comments (1)
verify_nzb.py (1)
118-141: 🎯 Functional Correctness | 🔵 Trivial | ⚡ Quick winAdd regression tests for the optimized escape path.
The supplied test covers only an ordinary unescaped body. Add cases for all four escaped encoded values, multiple escapes in one line, and a line ending with
=. Assert the exact decoded bytes, size, and CRC. AssertValueError("dangling yEnc escape")for the malformed line. yEnc requires the escape byte and its following byte to remain on the same line. (sources.debian.org)🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@verify_nzb.py` around lines 118 - 141, Add regression coverage for _decode_yenc_lines covering all four escaped encoded values, multiple escapes within one line, and a line ending in “=”. For each valid case, assert the exact decoded bytes, decoded size, and CRC; for the dangling escape case, assert ValueError with exactly “dangling yEnc escape”. Keep escape pairs on the same input line.
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@verify_nzb.py`:
- Around line 118-141: Add regression coverage for _decode_yenc_lines covering
all four escaped encoded values, multiple escapes within one line, and a line
ending in “=”. For each valid case, assert the exact decoded bytes, decoded
size, and CRC; for the dangling escape case, assert ValueError with exactly
“dangling yEnc escape”. Keep escape pairs on the same input line.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro Plus
Run ID: c1a4baf1-fa3b-4a62-ae70-c94dd7e2c20e
📒 Files selected for processing (1)
verify_nzb.py
📜 Review details
⏰ Context from checks skipped due to timeout. (1)
- GitHub Check: Codacy Static Code Analysis
🔇 Additional comments (1)
verify_nzb.py (1)
152-154: LGTM!Also applies to: 251-253, 289-295, 317-319, 437-450, 465-467, 527-529, 557-559, 571-575, 589-603, 629-632, 683-685, 713-715, 797-800, 809-811, 829-833, 878-880, 893-899, 912-924
1 participant
What: Replaced byte-by-byte iteration with C-backed bytes.find() and bytes.translate().
Why: yEnc decoding is a major bottleneck when verifying article bodies; manual byte iteration is very slow in Python.
Impact: ~15x faster decoding in benchmarks.
Measurement: Python timeit testing shows decoding time for typical articles drops from 0.033s to 0.0018s.
PR created automatically by Jules for task 1635191574344022785 started by @xbmc4lyfe