Scanbeam and offsets small optimizations - #1106
Open
avo-uxv wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @AngusJohnson,
Here are a couple of small targeted performance improvements, with the ulterior aim of speeding up zone fills in KiCAD (using the C++ version).
Testing
I added some tests for scanbeam and offsets in CPP and C# to test the correctness of these changes. Full disclaimer that I have not tested the delphi version
Benchmarking (CPP only)
Performance was measured with temporary google benchmark workloads comparing this branch against main using GCC release builds and one CPU core.
The workloads covered:
Overall, Scanbeam workloads improved by approximately 2.2% and offset workloads by 4–7%. Individual offset cases ranged from roughly 0 to 12% faster. Round-cap workloads showed some of the most consistent gains. Memory usage was effectively unchanged in the largest tested workloads.
The benchmarks were used for validation only and are not included in this PR
Looking forward to your feedback.