[Backport] fix(party): allow delegated access without instantiation rights#4327
Merged
Conversation
* party: allow delegated access without instantiation parties PartyProvider rejected every authenticated user whose allowed-to-instantiate party list was empty, even when the URL already identified an existing instance. This prevented delegated users from opening instances the backend authorized them to access. Limit the empty-party error to entry without an instance ID. Cover the distinction with a signing flow where the signer has real delegated access while the allowed-to-instantiate response is deliberately empty. * test: make existing instance access portable to TT02 Tenor party IDs differ between localtest and TT02, and newly delegated signing access is not reliable in TT02 due to authorization caching. Those environment details obscured the frontend regression the test is meant to protect. Select the organization by its stable Tenor number and reopen the instance as its original user. Mock only the instantiation-party response on the second load so the test isolates the frontend guard while retaining real backend instance authorization in both environments. * test: use Tenor user shared by localtest and TT02 The TT02-compatible regression initially used a Tenor identity that is not available in localtest, so the test could not validate the fix in both target environments. Use Human Andrefiolin and select their organization by its stable organization number. This keeps the instance authorization real while allowing the same negative-control test to run in podman and TT02. --------- Co-authored-by: Ole Martin Handeland <git@olemartin.org>
olemartinorg
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Backport of #4326
This is an automated backport of PR #4326 to the
release/v4.32release branch.Original PR
Changes
Cherry-picked the merge commit from the original PR onto the release branch.
🤖 This backport PR was created automatically by the Auto Backport workflow.