Removing sonarqube-scan

[olemartinorg]

Description

In #4320, the sonarqube scan is repeatedly failing. It's been on the brink of being removed from the project for a while now (I've been asked about it multiple times), but now that it actively started getting in the way it gets axed.

Related Issue(s)

• closes #{issue number}

Verification/QA

• Manual functionality testing
  • I have tested these changes manually
  • Creator of the original issue (or service owner) has been contacted for manual testing (or will be contacted when released in alpha)
  • No testing done/necessary
• Automated tests
  • Unit test(s) have been added/updated
  • Cypress E2E test(s) have been added/updated
  • No automatic tests are needed here (no functional changes/additions)
  • I want someone to help me make some tests
• UU/WCAG (follow these guidelines until we have our own)
  • I have tested with a screen reader/keyboard navigation/automated wcag validator
  • No testing done/necessary (no DOM/visual changes)
  • I want someone to help me perform accessibility testing
• User documentation @ altinn-studio-docs
  • Has been added/updated
  • No functionality has been changed/added, so no documentation is needed
  • I will do that later/have created an issue
• Support in Altinn Studio
  • Issue(s) created for support in Studio
  • This change/feature does not require any changes to Altinn Studio
• Sprint board
  • The original issue (or this PR itself) has been added to the Team Apps project and to the current sprint board
  • I don't have permissions to do that, please help me out
• Labels
  • I have added a kind/* and backport* label to this PR for proper release notes grouping
  • I don't have permissions to add labels, please help me out

Summary by CodeRabbit

• Chores
  • Simplified the automated validation workflow to run checkout, installation, type checks, linting, and unit tests.
  • Removed SonarCloud analysis from the pipeline.
  • Removed obsolete code-quality analysis configuration.

[coderabbitai]

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: 503da05a-0675-4b4a-85bc-f710ef8c13d2

📥 Commits

Reviewing files that changed from the base of the PR and between 5b41450 and 8d3f758.

📒 Files selected for processing (2)

• .github/workflows/unit-tests.yml
• sonar-project.properties

💤 Files with no reviewable changes (1)

• sonar-project.properties

---

📝 Walkthrough

Walkthrough

The unit-test workflow was renamed to reflect type-checking, linting, and unit tests, and its SonarCloud scan was removed. The SonarCloud project configuration file was also emptied.

Changes

SonarCloud CI removal

Layer / File(s)	Summary
Unit-test workflow cleanup .github/workflows/unit-tests.yml, sonar-project.properties	The workflow job name now lists only its remaining checks, ends after yarn test --coverage, and removes the SonarCloud project configuration.

Estimated code review effort: 2 (Simple) | ~10 minutes

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: removing the SonarQube scan from the workflow.
Description check	✅ Passed	The description follows the template and includes the required sections with QA details filled in.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Commit unit tests in branch chore/remove-sonarcloud

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands.}