intervention classes#98
Open
micahwoodard wants to merge 2 commits into
Open
Conversation
bruno-f-cruz
requested changes
Jul 13, 2026
bruno-f-cruz
left a comment
bruno-f-cruz
left a comment
Member
There was a problem hiding this comment.
Looks like a good and useful abstraction. I left a single comment so you dont have to maintain more class hiererchy and use shape-based Protocol instead.
| from abc import ABC, abstractmethod | ||
|
|
||
|
|
||
| class BaseIntervention(ABC): |
Member
There was a problem hiding this comment.
This doesn't implement any logic; consider using "Protocol" instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Architects intervention classes like bias and autowater