[PWGCF] Femto: add Lc support to the femto framework - #17424
Open
IgorPtak wants to merge 12 commits into
Open
Conversation
IgorPtak
marked this pull request as ready for review
August 12, 2026 08:57
IgorPtak
requested review from
alibuild,
ariedel-cern,
dimihayl,
dsarkaralice,
lauraser,
victor-gonzalez and
wrzesaCERN
as code owners
August 12, 2026 08:57
|
O2 linter results: ❌ 0 errors, |
Please consider the following formatting changes to AliceO2Group#17424
Collaborator
|
Error while checking build/O2Physics/code-check for 08c0583 at 2026-08-13 00:13: Full log here. |
Collaborator
|
Error while checking build/O2Physics/code-check for 9d8281e at 2026-08-17 08:07: Full log here. |
| mD0Cleaner2.init(confD0Cleaner2); | ||
|
|
||
| mD0HistManager1.template init<modeSe>(registry, D0HistSpec1, confD0Selection1, PosDauHistSpec1, NegDauHistSpec1); | ||
| mD0HistManager1.template init<modeSe>(registry, D0HistSpec1, confD0Selection1, PosDauHistSpec1, NegDauHistSpec1, NegDauHistSpec1); |
Collaborator
There was a problem hiding this comment.
I guess you add the negative daughter twice to match the signature of the new function. I would define two functions with different signatures for the 2 and 3 pronged candidates. This, I think, will be very confusing in the future.
| @@ -418,14 +440,28 @@ struct FemtoProducer { | |||
| template <modes::System system, typename T1, typename T2, typename T3> | |||
| void processD0s(T1 const& col, T2 const& tracks, T3 const& candidates) | |||
Collaborator
There was a problem hiding this comment.
Now looking at the code again, I think it is a bit wasteful to have a process function just for D0s and Lcs (I think we already have more than enough). Can you remove them and have at least processTracks{D0S,Lcs}?
Contributor
Author
There was a problem hiding this comment.
Do you mean mergin D0s and Lcs into processCharmHadrons? D0 and Lc come from different input tables, so merging them would make the DPL signature require both tables in every AO2D. Is there any solution to prevent this?
ariedel-cern
requested changes
Aug 19, 2026
ariedel-cern
left a comment
ariedel-cern
left a comment
Collaborator
There was a problem hiding this comment.
I left some small comment. Overall, everything looks good. I think the code-check posted one warning with regards to an used header.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds Lc baryons as a new particle species to the unified femto framework, enabling
Lc-hadron femtoscopic correlations.
Data model - four new tables:
FLcs- kinematics, mass of the accepted hypothesis and the three daughter indicesFLcMasks- selection bitmaskFLcExtras- QA/debug: mass of the competing hypothesis, three-prong topologicalvariables, BDT scores and the PWGHF selection flags
FLcLabels- MC labelsCore:
charmHadronBuilder.handcharmHadronHistManager.hextended to thethree-prong topology, so both species share the same builder and histogram manager.
Lc candidates are taken from PWGHF (
HfCand3Prong), with the acceptance applied asa rapidity cut via
HfHelper. Unlike D0, the sign of the stored signed pT is thephysical baryon charge, taken from the charge of the first prong - the PWGHF flags
only tell which mass assignment passed. Prongs are stored remapped onto the accepted
hypothesis, so
Prong0Daualways points at the proton.The naming of everything shared by the family was generalised from D0 to charm
hadron (
ConfD0Filters->ConfCharmHadronFilters,fillD0s->fillCharmHadrons,and so on). Species-level names (
D0Bits,D0Selection1) are unchanged.Tasks: the two D0 workflows now cover the whole family.
femto-charm-hadron-qa(wasfemto-d0-qa) - QA for D0 and Lc candidatesand their daughters
femto-pair-track-charm-hadron(wasfemto-pair-track-d0) - D0-hadron andLc-hadron correlations, same and mixed event
JSON prefixes changed accordingly:
D0Filters->CharmHadronFilters,D0Tables->CharmHadronTables.Pairs:
TrackLcPairCleanerandClosePairRejectionTrackLcare new.MC: Lc candidates have no direct MC label, so the three prongs are
matched to a generated Lc -> p K pi decay with
RecoDecay::getMatchedMCRec.Mass hypotheses: an Lc candidate can pass both the pKpi and the piKp hypothesis.
One row is stored per accepted hypothesis, so such a candidate appears twice, each
row with its own mass and prong assignment.
CharmHadronFilters.rejectAmbiguousHypothesisallows dropping them entirely.