Skip to content
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// Copyright 2019-2020 CERN and copyright holders of ALICE O2.

Check failure on line 1 in PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task]

Specify task name only when it cannot be derived from the struct name. Only append to the default name.
// See https://alice-o2.web.cern.ch/copyright for details of the copyright holders.
// All rights not expressly granted are reserved.
//
Expand Down Expand Up @@ -64,7 +64,7 @@
Produces<o2::aod::EMBCs_001> embc;
Produces<o2::aod::EMEvents> event;
Produces<o2::aod::EMEventsXY> eventXY;
// Produces<o2::aod::EMEventsCov> eventcov;
Produces<o2::aod::EMEventsCov> eventcov;
Produces<o2::aod::EMEventsMult> event_mult;
Produces<o2::aod::EMEventsCent> event_cent;
// Produces<o2::aod::EMEventsQvec> event_qvec;
Expand Down Expand Up @@ -170,7 +170,7 @@

eventXY(collision.posX(), collision.posY());

// eventcov(collision.covXX(), collision.covXY(), collision.covXZ(), collision.covYY(), collision.covYZ(), collision.covZZ(), collision.chi2());
eventcov(collision.covXX(), collision.covXY(), collision.covXZ(), collision.covYY(), collision.covYZ(), collision.covZZ(), collision.chi2());

event_mult(collision.multFT0A(), collision.multFT0C(), collision.multNTracksPV() /*, collision.multNTracksGlobal()*/);

Expand Down Expand Up @@ -205,7 +205,7 @@
float q2xft0m = 999.f, q2yft0m = 999.f, q2xft0a = 999.f, q2yft0a = 999.f, q2xft0c = 999.f, q2yft0c = 999.f, q2xfv0a = 999.f, q2yfv0a = 999.f, q2xbpos = 999.f, q2ybpos = 999.f, q2xbneg = 999.f, q2ybneg = 999.f, q2xbtot = 999.f, q2ybtot = 999.f;
float q3xft0m = 999.f, q3yft0m = 999.f, q3xft0a = 999.f, q3yft0a = 999.f, q3xft0c = 999.f, q3yft0c = 999.f, q3xfv0a = 999.f, q3yfv0a = 999.f, q3xbpos = 999.f, q3ybpos = 999.f, q3xbneg = 999.f, q3ybneg = 999.f, q3xbtot = 999.f, q3ybtot = 999.f;

if (collision.qvecFT0CReVec().size() >= 2) { // harmonics 2,3

Check failure on line 208 in PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number]

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
q2xft0m = collision.qvecFT0MReVec()[0], q2xft0a = collision.qvecFT0AReVec()[0], q2xft0c = collision.qvecFT0CReVec()[0], q2xfv0a = collision.qvecFV0AReVec()[0], q2xbpos = collision.qvecBPosReVec()[0], q2xbneg = collision.qvecBNegReVec()[0], q2xbtot = collision.qvecBTotReVec()[0];
q2yft0m = collision.qvecFT0MImVec()[0], q2yft0a = collision.qvecFT0AImVec()[0], q2yft0c = collision.qvecFT0CImVec()[0], q2yfv0a = collision.qvecFV0AImVec()[0], q2ybpos = collision.qvecBPosImVec()[0], q2ybneg = collision.qvecBNegImVec()[0], q2ybtot = collision.qvecBTotImVec()[0];
q3xft0m = collision.qvecFT0MReVec()[1], q3xft0a = collision.qvecFT0AReVec()[1], q3xft0c = collision.qvecFT0CReVec()[1], q3xfv0a = collision.qvecFV0AReVec()[1], q3xbpos = collision.qvecBPosReVec()[1], q3xbneg = collision.qvecBNegReVec()[1], q3xbtot = collision.qvecBTotReVec()[1];
Expand Down Expand Up @@ -344,7 +344,7 @@
WorkflowSpec defineDataProcessing(ConfigContext const& cfgc)
{
return WorkflowSpec{
adaptAnalysisTask<CreateEMEventDilepton>(cfgc, TaskName{"create-emevent-dilepton"}),

Check failure on line 347 in PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task]

Device names create-emevent-dilepton and create-e-m-event-dilepton generated from the specified task name create-emevent-dilepton and from the struct name CreateEMEventDilepton, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to CreateEmeventDilepton and removing TaskName.
adaptAnalysisTask<AssociateDileptonToEMEvent>(cfgc, TaskName{"associate-dilepton-to-emevent"}),

Check failure on line 348 in PWGEM/Dilepton/TableProducer/createEMEventDilepton.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[name/o2-task]

Device names associate-dilepton-to-emevent and associate-dilepton-to-e-m-event generated from the specified task name associate-dilepton-to-emevent and from the struct name AssociateDileptonToEMEvent, respectively, differ in hyphenation. Consider fixing capitalisation of the struct name to AssociateDileptonToEmevent and removing TaskName.
};
}
Loading