Skip to content

[PWGEM/Dilepton] fix duplicated pairs in studyDCAFitter.cxx #16605

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dsekihat merged 1 commit into from
Jun 10, 2026
+8 −14
Merged

[PWGEM/Dilepton] fix duplicated pairs in studyDCAFitter.cxx #16605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 8 additions & 14 deletions PWGEM/Dilepton/Tasks/studyDCAFitter.cxx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -431,7 +431,7 @@
fRegistry.fill(HIST("Pair/PV/Zboson/uls/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 1) { // LS++
fRegistry.fill(HIST("Pair/PV/Zboson/lspp/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 2) { // LS--

Check failure on line 434 in PWGEM/Dilepton/Tasks/studyDCAFitter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
fRegistry.fill(HIST("Pair/PV/Zboson/lsmm/hs"), v12.M(), v12.Pt(), pair_dca);
}
break;
Expand All @@ -441,7 +441,7 @@
fRegistry.fill(HIST("Pair/PV/PromptJpsi/uls/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 1) { // LS++
fRegistry.fill(HIST("Pair/PV/PromptJpsi/lspp/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 2) { // LS--

Check failure on line 444 in PWGEM/Dilepton/Tasks/studyDCAFitter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
fRegistry.fill(HIST("Pair/PV/PromptJpsi/lsmm/hs"), v12.M(), v12.Pt(), pair_dca);
}
} else { // nonprompt
Expand All @@ -449,7 +449,7 @@
fRegistry.fill(HIST("Pair/PV/NonPromptJpsi/uls/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 1) { // LS++
fRegistry.fill(HIST("Pair/PV/NonPromptJpsi/lspp/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 2) { // LS--

Check failure on line 452 in PWGEM/Dilepton/Tasks/studyDCAFitter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
fRegistry.fill(HIST("Pair/PV/NonPromptJpsi/lsmm/hs"), v12.M(), v12.Pt(), pair_dca);
}
}
Expand All @@ -464,7 +464,7 @@
fRegistry.fill(HIST("Pair/PV/c2e_c2e/uls/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 1) { // LS++
fRegistry.fill(HIST("Pair/PV/c2e_c2e/lspp/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 2) { // LS--

Check failure on line 467 in PWGEM/Dilepton/Tasks/studyDCAFitter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
fRegistry.fill(HIST("Pair/PV/c2e_c2e/lsmm/hs"), v12.M(), v12.Pt(), pair_dca);
}
break;
Expand All @@ -473,7 +473,7 @@
fRegistry.fill(HIST("Pair/PV/b2e_b2e/uls/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 1) { // LS++
fRegistry.fill(HIST("Pair/PV/b2e_b2e/lspp/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 2) { // LS--

Check failure on line 476 in PWGEM/Dilepton/Tasks/studyDCAFitter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
fRegistry.fill(HIST("Pair/PV/b2e_b2e/lsmm/hs"), v12.M(), v12.Pt(), pair_dca);
}
break;
Expand All @@ -482,7 +482,7 @@
fRegistry.fill(HIST("Pair/PV/b2c2e_b2c2e/uls/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 1) { // LS++
fRegistry.fill(HIST("Pair/PV/b2c2e_b2c2e/lspp/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 2) { // LS--

Check failure on line 485 in PWGEM/Dilepton/Tasks/studyDCAFitter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
fRegistry.fill(HIST("Pair/PV/b2c2e_b2c2e/lsmm/hs"), v12.M(), v12.Pt(), pair_dca);
}
break;
Expand All @@ -491,7 +491,7 @@
fRegistry.fill(HIST("Pair/PV/b2c2e_b2e_sameb/uls/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 1) { // LS++
fRegistry.fill(HIST("Pair/PV/b2c2e_b2e_sameb/lspp/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 2) { // LS--

Check failure on line 494 in PWGEM/Dilepton/Tasks/studyDCAFitter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
fRegistry.fill(HIST("Pair/PV/b2c2e_b2e_sameb/lsmm/hs"), v12.M(), v12.Pt(), pair_dca);
}
break;
Expand All @@ -500,7 +500,7 @@
fRegistry.fill(HIST("Pair/PV/b2c2e_b2e_diffb/uls/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 1) { // LS+diff
fRegistry.fill(HIST("Pair/PV/b2c2e_b2e_diffb/lspp/hs"), v12.M(), v12.Pt(), pair_dca);
} else if constexpr (signType == 2) { // LS-diff

Check failure on line 503 in PWGEM/Dilepton/Tasks/studyDCAFitter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
fRegistry.fill(HIST("Pair/PV/b2c2e_b2e_diffb/lsmm/hs"), v12.M(), v12.Pt(), pair_dca);
}
break;
Expand Down Expand Up @@ -560,7 +560,7 @@
return;
}
const auto& vtx = fitter.getPCACandidate();
for (int i = 0; i < 3; i++) {

Check failure on line 563 in PWGEM/Dilepton/Tasks/studyDCAFitter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[magic-number] 

Avoid magic numbers in expressions. Assign the value to a clearly named variable or constant.
svpos[i] = vtx[i];
}
fitter.getTrack(0).getPxPyPzGlo(pvec0);
Expand Down Expand Up @@ -821,7 +821,7 @@
if (!mctrack.has_mothers()) {
continue;
}
if (std::abs(mctrack.pdgCode()) != 11) {

Check failure on line 824 in PWGEM/Dilepton/Tasks/studyDCAFitter.cxx

View workflow job for this annotation

GitHub Actions / O2 linter

[pdg/explicit-code] 

Avoid hard-coded PDG codes. Use named values from PDG_t or o2::constants::physics::Pdg instead.
continue;
}

Expand Down Expand Up @@ -858,25 +858,19 @@
} // end of electron loop
} // end of positron loop

for (const auto& posId1 : positronIds) {
auto pos1 = tracks.rawIteratorAt(posId1);
for (const auto& posId2 : positronIds) {
auto pos2 = tracks.rawIteratorAt(posId2);
if (pos1.globalIndex() == pos2.globalIndex()) {
continue;
}
for (size_t i = 0; i < positronIds.size(); i++) {
auto pos1 = tracks.rawIteratorAt(positronIds[i]);
for (size_t j = i + 1; j < positronIds.size(); j++) {
auto pos2 = tracks.rawIteratorAt(positronIds[j]);
runSVFinder<1>(collision, pos1, pos2, mcParticles);
runPairingAtPV<1>(pos1, pos2, mcParticles);
} // end of positron loop
} // end of positron loop

for (const auto& eleId1 : electronIds) {
auto ele1 = tracks.rawIteratorAt(eleId1);
for (const auto& eleId2 : electronIds) {
auto ele2 = tracks.rawIteratorAt(eleId2);
if (ele1.globalIndex() == ele2.globalIndex()) {
continue;
}
for (size_t i = 0; i < electronIds.size(); i++) {
auto ele1 = tracks.rawIteratorAt(electronIds[i]);
for (size_t j = i + 1; j < electronIds.size(); j++) {
auto ele2 = tracks.rawIteratorAt(electronIds[j]);
runSVFinder<2>(collision, ele1, ele2, mcParticles);
runPairingAtPV<2>(ele1, ele2, mcParticles);
} // end of electron loop
Expand Down
Loading