Skip to content

Rotation2D: use sincos #15691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
davidrohr merged 1 commit into from
Aug 19, 2026
+3 −3
Merged

Rotation2D: use sincos #15691

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions Common/MathUtils/include/MathUtils/Cartesian.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,7 @@

#include "GPUROOTCartesianFwd.h"
#include "GPUROOTSMatrixFwd.h"
#include "MathUtils/detail/trigonometric.h"

namespace o2
{
Expand Down Expand Up @@ -68,7 +69,7 @@ class Rotation2D

Rotation2D() = default;
Rotation2D(value_t cs, value_t sn) : mCos(cs), mSin(sn) {}
Rotation2D(value_t phiZ) : mCos(cos(phiZ)), mSin(sin(phiZ)) {}
Rotation2D(value_t phiZ) { detail::sincos<value_t>(phiZ, mSin, mCos); }
~Rotation2D() = default;
Rotation2D(const Rotation2D& src) = default;
Rotation2D(Rotation2D&& src) = default;
Expand All @@ -77,8 +78,7 @@ class Rotation2D

void set(value_t phiZ)
{
mCos = cos(phiZ);
mSin = sin(phiZ);
detail::sincos<value_t>(phiZ, mSin, mCos);
}

void set(value_t cs, value_t sn)
Expand Down
Loading