AOD: don't emit MC collisions borrowed from the previous timeframe#15509
Open
sawenzel wants to merge 1 commit into
Open
AOD: don't emit MC collisions borrowed from the previous timeframe#15509sawenzel wants to merge 1 commit into
sawenzel wants to merge 1 commit into
Conversation
With --orbitsEarly (the timeframe history effect in O2DPG), the per-TF collision context is prefixed with the tail collisions of the previous timeframe. The AOD producer emitted BC and McCollision rows (plus McParticles) for these borrowed collisions as well, so merging per-TF AODs produced duplicate, non-monotonic BC entries and double-counted MC events. We now apply an ownership cut at mStartIR (orbitFirstSampled): collisions with globalBC below the TF start are skipped in collectBCs, the McCollision table and the McParticles table. McCollision indices are compacted accordingly, and reconstructed-track MC labels pointing into a dropped collision are invalidated (-1). The cut is applied uniformly to every TF, including the first one of a job, so that AODs of neighbouring jobs can also be merged without duplication. Merged AO2Ds now have a sorted, duplicate-free BC table and exactly one McCollision row per generated event, making the post-hoc AODBcRewriter (in O2DPG) repair unnecessary for new productions.
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With --orbitsEarly (the timeframe history effect in O2DPG), the per-TF collision context is prefixed with the tail collisions of the previous timeframe. The AOD producer emitted BC and McCollision rows (plus McParticles) for these borrowed collisions as well, so merging per-TF AODs produced duplicate, non-monotonic BC entries and double-counted MC events.
We now apply an ownership cut at mStartIR (orbitFirstSampled): collisions with globalBC below the TF start are skipped in collectBCs, the McCollision table and the McParticles table. McCollision indices are compacted accordingly, and reconstructed-track MC labels pointing into a dropped collision are invalidated (-1).
The cut is applied uniformly to every TF, including the first one of a job, so that AODs of neighbouring jobs can also be merged without duplication. Merged AO2Ds now have a sorted, duplicate-free BC table and exactly one McCollision row per generated event, making the post-hoc AODBcRewriter (in O2DPG) repair unnecessary for new productions.