DPL: allow narrowing of large joins#15506
Open
ktf wants to merge 1 commit into
Open
Conversation
This allows narrowing of large joins when they are not strictly necessary, allowing to simplify iteration and reducing the scope of helper functions and alikes.
Member
Author
|
@aalkin what do you think of this? |
Member
|
I'm not sure as to what this is going to achieve. The iteration is not a heavy operation, the actual calculation of the pointer happens only when a column getter is called. The helper functions as a rule consume references to tables, so using this one would instead pay to construct a new (if lighter) set of iterators. The only usage I can think of, are non-templated helper functions. If we implement narrowing as a conversion operator in the Table/Join class, then it would be possible to have helper functions, that require only part of a join, defined out-of-line with a concrete type. |
Collaborator
|
Error while checking build/O2/fullCI_slc9 for 13071e7 at 2026-06-10 16:11: Full log here. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This allows narrowing of large joins when they are not strictly necessary, allowing to simplify iteration and reducing the scope of helper functions and alikes.