[#540] Add concurrency-safe idempotency for charges - #554
Open
arisu6804 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a production-shaped charge write path with concurrency-safe, tenant-scoped idempotency for
POST /api/v1/charges.What changed
ChargeIdempotencyStorecontract and atomic in-memory claim state machine.Acceptance criteria
src/routes/charges.ts, route test).409 idempotency_conflict.409 request_in_progressbefore a second side effect.400response.Verification
npm run buildnode --test dist/charges.test.js— 17/17 passingnpm run lintThe repository-wide legacy test command was also attempted. Existing parallel test-isolation suites report unrelated shared-state/timeouts in this checkout; the new focused suite is deterministic and passes independently.
Operational note
The shipped adapter is intentionally in-memory, as requested by the issue. A multi-process deployment must provide a shared implementation of
ChargeIdempotencyStorebefore relying on exactly-once behavior across process boundaries.Closes #540