Support function expressions in table settings - #317
Merged
git-hulk merged 1 commit intoAug 28, 2026
Conversation
git-hulk
approved these changes
Aug 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Allow table
SETTINGSvalues to use expressions in addition to scalar literals.This adds support for ClickHouse table-disk definitions such as:
It also supports nested disk definitions used by cached reader tables.
Why
The parser currently rejects function expressions in table settings:
This prevents callers from parsing
SHOW CREATE TABLEoutput for tables usings3_plain_rewritableand cache disks.Validation
go test ./... -count=1go vet ./...still reports the existingFormatter.WriteBytesignature warning inparser/format.go.