feat: add ignoreWhitespace prop to ignore leading and trailing spaces - #98
Open
robbertbrak wants to merge 1 commit into
Open
feat: add ignoreWhitespace prop to ignore leading and trailing spaces#98robbertbrak wants to merge 1 commit into
robbertbrak wants to merge 1 commit into
Conversation
Lines that differ only in leading or trailing whitespace were always
reported as changes, with no way to opt out.
`compareMethod` cannot be used for this: it is only threaded into the
word diff computed *within* an already-changed line, while the line diff
itself is hardcoded to `diff.diffLines(old, new, { newlineIsToken: false })`.
Passing `DiffMethod.TRIMMED_LINES` therefore has no effect on which lines
are marked as changed.
Add an `ignoreWhitespace` prop that is forwarded to jsDiff's diffLines().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Lines that differ only in leading or trailing whitespace were always reported as changes, with no way to opt out.
compareMethodcannot be used for this: it is only threaded into the word diff computed within an already-changed line, while the line diff itself is hardcoded todiff.diffLines(old, new, { newlineIsToken: false }). PassingDiffMethod.TRIMMED_LINEStherefore has no effect on which lines are marked as changed.This PR adds an
ignoreWhitespaceprop that is forwarded to jsDiff's diffLines().