WEBCORE-2676: Remove ds-patched.model.is-destroyed deprecation and guard#16
Draft
jiayingxu wants to merge 1 commit into
Draft
WEBCORE-2676: Remove ds-patched.model.is-destroyed deprecation and guard#16jiayingxu wants to merge 1 commit into
jiayingxu wants to merge 1 commit into
Conversation
This removes the custom patch that added an early-exit guard when getRecord() is called on a destroyed InternalModel. The goal is to assess the impact of this removal on Iverson to better understand whether this behavior will be needed when upgrading to mainline 3.28. This reverts the custom fork changes originally introduced in: - 400aaea by Alex Navasardyan (2022) - e30f989 by Martin Munoz (2023) Related to WEBCORE-2676 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes the custom
ds-patched.model.is-destroyeddeprecation and the!this.isDestroyedguard from Ember Data'sInternalModel.getRecord()method.The original patch (introduced by Alex Navasardyan in 2022, ported to TypeScript by Martin Munoz in 2023) added an early-exit guard to prevent record materialization when
getRecord()is called on destroyed InternalModels. This was needed to unblock an Ember 3.4 upgrade at the time.The goal of this PR is to roll back this custom behavior on our v3.12.6 fork and assess the impact on Iverson. When we later attempt to upgrade to the mainline of Ember Data 3.28, we can compare how it behaves to this version of our fork without the patch, helping us understand if this custom patch is still necessary.
Changes:
isDestroyedwas true&& !this.isDestroyedguard from the materialization conditionRelated commits:
Summary
Ticket: https://addepar.atlassian.net/browse/WEBCORE-2676
Release notes: none